Sheffield | 25-ITP-SEP | Declan Williams | Sprint 1 | structuring and testing data #876
Closed
CatchingKiyoko wants to merge 12 commits intoCodeYourFuture:mainfrom
Closed
Conversation
…y converted into a string so that .Slice can be used and produce no errors.
…ier is directly after a number.
…nd calculations in time format code
…se behind the steps
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
CatchingKiyoko
added
📅 Sprint 1
cjyuan
reviewed
Nov 15, 2025
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Code looks good.
You mentioned Jest test in the PR description, but I don't see any Jest test on this branch though. Can you update the PR description accordingly?
cjyuan
added
Reviewed
CatchingKiyoko
added
Needs Review
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist