You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR adds filename titles to a few code blocks using the title attribute to make examples clearer for learners.
It follows the suggestion from issue #175 to annotate code snippets with meaningful file names.
Please let me know if any changes are needed.
Thanks!
Thanks for taking a look at this! Unfortunately, I don't think the codeblock rendering shortcode actually supports this right now, so we need to build some template support to show this - we can't just add title= to the existing codeblocks.
Also unfortunately, the file you picked up editing actually isn't included in the curriculum anywhere at the moment! But I've just written up some mentoring instructions in #175 (comment)
If you're interested, try getting our curriculum running locally (I recommend running org-cyf-itp using these instructions and try following the mentoring attached to the issue :)
I'm going to close this PR for now, because it doesn't quite do the right thing it needs to, but feel free to either re-open it, or open a new one, if you make progress! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-project-automation
Bot
moved this from 📋 Backlog
to ✅ Done
in Curriculum Planning
This PR adds filename titles to a few code blocks using the
titleattribute to make examples clearer for learners.It follows the suggestion from issue #175 to annotate code snippets with meaningful file names.
Please let me know if any changes are needed.
Thanks!
Fixes #175