Subscription client changes #424
Conversation
|
Brandon says: |
brandonkachen
left a comment
brandonkachen
left a comment
There was a problem hiding this comment.
mostly looks good, just needs some de-slopification. one key issue to fix/consciously ignore before merging: https://github.com/CodebuffAI/codebuff/pull/424/changes#r2748507503
| ⏱️ Block limit reached | ||
| </text> | ||
| <text style={{ fg: theme.muted }}> | ||
| You've used all {rateLimit.blockLimit?.toLocaleString()} credits in this 5-hour block. |
There was a problem hiding this comment.
nit: we should use the constant for the block size.
There was a problem hiding this comment.
also, if rateLimit.blockLimit doesn't exist, we should put a placeholder string, e.g. "your" -> "You've used all credits..."
| <> | ||
| <Button onClick={handleContinueWithCredits}> | ||
| <text style={{ fg: theme.foreground }}> | ||
| [Continue with a-la-carte] ({remainingBalance.toLocaleString()} available) |
There was a problem hiding this comment.
should we make these look like proper buttons? like our /feedback submit button?
| <ProgressBar | ||
| percentAvailable={ | ||
| rateLimit.blockLimit != null && rateLimit.blockUsed != null && rateLimit.blockLimit > 0 | ||
| ? 100 - (rateLimit.blockUsed / rateLimit.blockLimit) * 100 |
There was a problem hiding this comment.
wait we shouldn't pass back the actual amounts from the server to the client; only the server should know how much is actually used, the client should only ever see percentages
| Upgrade to {SUBSCRIPTION_DISPLAY_NAME} | ||
| </h3> | ||
| <p className="text-sm text-muted-foreground"> | ||
| From $100/mo · Work in focused 5-hour sessions with no |
There was a problem hiding this comment.
we're not releasing tiers yet, right? so this number should be the tier we actually want to show users. and if we're gonna hardcode something, it should be the $200/mo plan.
| const canonicalUrl = `${env.NEXT_PUBLIC_CODEBUFF_APP_URL}/strong` | ||
| const title = `Codebuff ${SUBSCRIPTION_DISPLAY_NAME} — The Strongest Coding Agent` | ||
| const description = | ||
| 'Deep thinking, multi-agent orchestration, and the strongest coding agent. Plans from $100/mo.' |
There was a problem hiding this comment.
hardcoded $100 again
…n indicator in message footer
No description provided.