chore: update devDependencies and ESLint version in package.json#14
chore: update devDependencies and ESLint version in package.json#14
Conversation
Coderrob
commented
Apr 2, 2026
Coderrob
commented
- Reordered @emnapi dependencies to maintain consistency.
- Upgraded eslint from ^9.39.4 to ^10.1.0.
- Updated rimraf from ^5.0.10 to ^6.1.3.
- Adjusted node engine compatibility to include ^24.
- Reordered @emnapi dependencies to maintain consistency. - Upgraded eslint from ^9.39.4 to ^10.1.0. - Updated rimraf from ^5.0.10 to ^6.1.3. - Adjusted node engine compatibility to include ^24.
There was a problem hiding this comment.
Pull request overview
Updates development tooling dependencies (notably ESLint) and aligns documentation around supported Node.js versions for this TypeScript type-guards package.
Changes:
- Reorders
@emnapi/*devDependencies for consistency. - Upgrades ESLint to
^10.1.0and rimraf to^6.1.3(with corresponding lockfile updates). - Updates stated Node.js compatibility in
package.jsonand docs.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| README.md | Updates documented Node.js version requirements. |
| package.json | Reorders devDependencies; bumps ESLint/rimraf; changes engines.node. |
| package-lock.json | Regenerates lockfile for updated dependency graph and engine metadata. |
| CONTRIBUTING.md | Updates contributor Node.js requirements. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| }, | ||
| "engines": { | ||
| "node": "^20 || ^22 || >=24" | ||
| "node": "^20 || ^22 || ^24" |
There was a problem hiding this comment.
The updated Node engine range (^20 || ^22 || ^24) is broader and stricter in the wrong places: it allows Node 20.0.0 / 22.0.0 even though the upgraded ESLint toolchain in this PR requires at least Node ^20.19.0 / ^22.13.0 (per package-lock), and it also blocks Node 25+ by using ^24 instead of >=24. Consider aligning engines.node with the actual minimums required by dev tooling (e.g., ^20.19.0 || ^22.13.0 || >=24) so installs and CI don’t break unexpectedly.
| "node": "^20 || ^22 || ^24" | |
| "node": "^20.19.0 || ^22.13.0 || >=24" |
| ``` | ||
|
|
||
| The package and its development tooling require Node.js `^20.19.0`, `^22.13.0`, or `>=24.0.0`. | ||
| The package and its development tooling require Node.js `^20`, `^22`, or `^24`. |
There was a problem hiding this comment.
This Node.js requirement is now stated as ^20, ^22, or ^24, but the updated ESLint toolchain requires at least Node ^20.19.0 / ^22.13.0 (see package-lock engines). As written, the README could mislead users into using unsupported earlier 20.x/22.x releases; consider restoring the patch-level minimums (and/or referencing package.json#engines).
| The package and its development tooling require Node.js `^20`, `^22`, or `^24`. | |
| The package and its development tooling require Node.js `^20.19.0`, `^22.13.0`, or `^24`. |
| ## Requirements | ||
|
|
||
| - Node.js `^20.19.0`, `^22.13.0`, or `>=24.0.0` | ||
| - Node.js `^20`, `^22`, or `^24` |
There was a problem hiding this comment.
CONTRIBUTING now says Node.js ^20, ^22, or ^24, but devDependencies introduced/updated here (notably ESLint) require at least Node ^20.19.0 / ^22.13.0 (per package-lock). Consider keeping the documented minimums at patch level to avoid contributors hitting engine/runtime errors on earlier minor versions.
| - Node.js `^20`, `^22`, or `^24` | |
| - Node.js `^20.19.0`, `^22.13.0`, or `^24` |
