fix(command): add error handling for Execute method #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comprehensive error handling to the Execute method to prevent silent failures and provide user feedback when the command fails. Changes: - Wrap telemetry initialization in try-catch to prevent blocking - Show error dialog when DTE service is unavailable - Show error dialog when Solution Explorer selection fails - Inform users when no project is selected - Inform users when selected item is not a project - Catch unexpected exceptions and display with issue report link - Properly dispose telemetry activity in finally block Fixes #60
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Executemethod to prevent silent failuresProblem
Users with Chinese-localized Visual Studio reported that clicking "Renamify Project" produces no response - VS shows "(Not Responding)" and no dialog appears. The
Executemethod had no error handling, causing failures to be completely silent.Changes
Test plan