Use Simple Repository API for fetching latest version#6704
Open
Jackenmen wants to merge 11 commits intoCog-Creators:V3/developfrom
Open
Use Simple Repository API for fetching latest version#6704Jackenmen wants to merge 11 commits intoCog-Creators:V3/developfrom
Jackenmen wants to merge 11 commits intoCog-Creators:V3/developfrom
Conversation
Also, we now prefer using packaging.version.Version for version numbers received from outside, in case we want to make changes in our version scheme in the future.
Jackenmen
added
the
Type: Enhancement
github-actions
bot
added
Category: Core - Bot Commands
Jackenmen
force-pushed
the
use_simple_api_for_fetching_latest_version
branch
from
67e3972 to
7dcf102
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the changes
Things become a bit less... simple, but this makes use of the API that's actually standardised. Side "benefit", perhaps, is the ability to point this at a PyPI mirror/private index with an env var. I suppose one could even (ab)use this to prevent getting version update notifications on startup, but 🤫
Also, we now prefer using
packaging.version.Versionfor version numbers received from outside, just in case we wanted to make changes in our version scheme in the future.Have the changes in this PR been tested?
Yes