Skip to content

Fix remaining issues with internal Downloader API#6721

Merged
Flame442 merged 3 commits intoCog-Creators:V3/developfrom
Jackenmen:fix_downloader_things_after_coverage
Apr 7, 2026
Merged

Fix remaining issues with internal Downloader API#6721
Flame442 merged 3 commits intoCog-Creators:V3/developfrom
Jackenmen:fix_downloader_things_after_coverage

Conversation

@Jackenmen
Copy link
Copy Markdown
Member

Description of the changes

Fixes regressions from #6706:

  • "---" being appended when all cogs failed to install
    • The prefix will also no longer be shown when none of the cogs has an install message, though that was not part of the regression
  • Incorrect type hints
  • Wrong argument being passed to _update_cogs() when repo fails to update in cog updatetoversion

Have the changes in this PR been tested?

Yes

@Jackenmen Jackenmen added this to the 3.5.25 milestone Mar 31, 2026
@Jackenmen Jackenmen added Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. Release Blocker This needs handling prior to the next non-hotfix release. Changelog Entry: Skipped Changelog entry for this PR is unnecessary. labels Mar 31, 2026
@github-actions github-actions Bot added Category: Cogs - Downloader This is related to the Downloader cog. Category: Core - Downloader This is related to the internal Downloader APIs. labels Mar 31, 2026
@Flame442 Flame442 self-assigned this Apr 7, 2026
@Flame442 Flame442 merged commit 6ceb45b into Cog-Creators:V3/develop Apr 7, 2026
20 checks passed
@Jackenmen Jackenmen deleted the fix_downloader_things_after_coverage branch April 8, 2026 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Category: Cogs - Downloader This is related to the Downloader cog. Category: Core - Downloader This is related to the internal Downloader APIs. Changelog Entry: Skipped Changelog entry for this PR is unnecessary. Release Blocker This needs handling prior to the next non-hotfix release. Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants