fix: correct operator precedence in install command validation#365
Merged
bigcat88 merged 2 commits intoComfy-Org:mainfrom Mar 11, 2026
Merged
fix: correct operator precedence in install command validation#365bigcat88 merged 2 commits intoComfy-Org:mainfrom
bigcat88 merged 2 commits intoComfy-Org:mainfrom
Conversation
dosubot
bot
added
size:XS
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #365 +/- ##
==========================================
+ Coverage 52.49% 52.52% +0.02%
==========================================
Files 32 32
Lines 3568 3568
==========================================
+ Hits 1873 1874 +1
+ Misses 1695 1694 -1
🚀 New features to boost your workflow:
|
Fixed issue Comfy-Org#335: --pr cannot be used with --version or --commit The condition "pr and version not in {None, \"nightly\"} or commit" was evaluated incorrectly due to operator precedence. Added parentheses to ensure the logic only triggers error when --pr is actually combined with conflicting flags, not when only --commit is specified. Co-Authored-By: Claude <noreply@anthropic.com>
Xyc2016
force-pushed
the
fix-specify-commit
branch
from
c0538e5 to
b77bbef
Compare
dosubot
bot
added
size:S
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes install command flag validation to correctly apply operator precedence so --commit no longer triggers a --pr conflict unless --pr is actually provided (issue #335).
Changes:
- Add parentheses to the
--pr/--version/--commitconflict condition ininstall. - Add a regression test ensuring
--commitwithout--prdoes not emit the--prconflict error and still calls install execution.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
comfy_cli/cmdline.py |
Fixes boolean condition precedence in install flag conflict validation. |
tests/comfy_cli/command/github/test_pr.py |
Adds regression test coverage for issue #335 (--commit without --pr). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
bigcat88
approved these changes
Mar 11, 2026
Contributor
bigcat88
left a comment
bigcat88
left a comment
There was a problem hiding this comment.
PR looks good - merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed issue #335: --pr cannot be used with --version or --commit
The condition "pr and version not in {None, "nightly"} or commit" was evaluated incorrectly due to operator precedence. Added parentheses to ensure the logic only triggers error when --pr is actually combined with conflicting flags, not when only --commit is specified.