Add request_id match logic for radas message receiver#301
Merged
yma955 merged 1 commit intoCommonjava:mainfrom May 29, 2025
Merged
Add request_id match logic for radas message receiver#301yma955 merged 1 commit intoCommonjava:mainfrom
yma955 merged 1 commit intoCommonjava:mainfrom
Conversation
Pull Request Test Coverage Report for Build 15289854030Details
💛 - Coveralls |
ebdb929 to
c970571
Compare
Member
|
@yma96 Actually we still miss one part of the logic. If you check the tech design, you will see that the response file will give fields "signing_status" and "errors". That means it will possibly get errors in radas side. We should cover this part of handling. What I'm thinking here is, we should have a field in Receiver to tell if the response is successful or failed, and field to record the errors. Then in main process we can control based on these fields. WDYT? |
Member
Author
|
@ligangty That sounds good, I'll have another PR to handle the response, will merge this first, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.