Add sign response status and errors for receiver then use to control the main process#302
Merged
yma955 merged 1 commit intoCommonjava:mainfrom May 29, 2025
Merged
Add sign response status and errors for receiver then use to control the main process#302yma955 merged 1 commit intoCommonjava:mainfrom
yma955 merged 1 commit intoCommonjava:mainfrom
Conversation
Pull Request Test Coverage Report for Build 15317191896Details
💛 - Coveralls |
ligangty
reviewed
May 29, 2025
| super().__init__() | ||
| self.sign_result_loc = sign_result_loc | ||
| self.request_id = request_id | ||
| self.sign_result_status = "success" |
Member
There was a problem hiding this comment.
This does not make sense, because it is asynchronized accessed in main process. If we set it in init method, it means it will be "success" at start time, even that the receiver does not get any message yet from UMB. Instead we should set it as None, then loop and waiting to check it to be a not None value to continue.
ligangty
approved these changes
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.