Refactor: refactor the RadasSender#303
Conversation
ligangty
commented
Jun 4, 2025
- rename radas_signature_handler.py to radas_sign.py
- change RadasSender logic:
- add retry logic
- add error handling
- avoid duplicate message sending
- use a global RadasConfig instead created one in each Radas class
* rename radas_signature_handler.py to radas_sign.py * change RadasSender logic: * add retry logic * add error handling * avoid duplicate message sending * use a global RadasConfig instead created one in each Radas class
Pull Request Test Coverage Report for Build 15433363274Details
💛 - Coveralls |
|
And one other thing is in official examples they use a monolith client class to handle both send and listen, so it can also do listen and send at the same time, and it can also identify if the message received is reply message of previous sent message, are we not going to implement that way? |
I'd prefer not to do this, because our Receiver and Sender have different handling logic, different control flow and different virtual topics to send/listen. Use separated Sender and Receiver classes can make it clearer and more readable. |
|
@shokakucarrier I'll merge this now. If you found something not correct, feel free to submit PR to fix it. |