Reskinnable Throw Boxes + "can pass through Spinners" option#11
Merged
catapillie merged 7 commits intoCommunalHelper:devfrom Jul 12, 2025
Merged
Reskinnable Throw Boxes + "can pass through Spinners" option#11catapillie merged 7 commits intoCommunalHelper:devfrom
catapillie merged 7 commits intoCommunalHelper:devfrom
Conversation
… through Spinners
catapillie
approved these changes
Jul 12, 2025
Contributor
catapillie
left a comment
catapillie
left a comment
There was a problem hiding this comment.
Looks good! Thanks for fixing the hook not unloading, that was pretty bad.
I know \0 is the tile ID for air, but I think it still makes more sense to work with a nullable character. But this is just a nitpick really, don't worry about it.
Comment on lines
+23
to
+33
| public static void Unload() { | ||
| On.Celeste.Player.ctor -= ctor; | ||
| On.Celeste.Level.LoadLevel -= LoadLevel; | ||
| On.Celeste.Player.Die -= PlayerDie; | ||
| On.Celeste.LevelExit.Routine -= RespawnRoutine; | ||
| On.Celeste.Player.Pickup -= Pickup; | ||
| On.Celeste.Lookout.LookRoutine -= LookRoutine; | ||
| On.Celeste.LevelEnter.Go -= LevelEnterGo; | ||
| On.Celeste.DashBlock.Break_Vector2_Vector2_bool_bool -= DashBlockBreak; | ||
| On.Celeste.DashBlock.RemoveAndFlagAsGone -= DashBlockRemoveAndFlagAsGone; | ||
| } |
Contributor
There was a problem hiding this comment.
whaaaaaaaaaaaaaa
THANK YOU for this
| for (int i = 0; i < Width / 8f; i++) { | ||
| for (int j = 0; j < Height / 8f; j++) { | ||
| if (_isMetal) { | ||
| if (_debrisTypeOverride != '\0') { |
Contributor
There was a problem hiding this comment.
Perhaps it would make more sense to use a nullable char rather than checking for a magic \0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds several options to the Throw Box and Throw Box Spawner entities to customise their textures, their impact particles, and their debris, as well as an option to let them pass through Spinners safely.
This hasn't been fully tested, so any feedback would be appreciated.
Other changes: