De-duplicate our WinUI2/3 workflow definitions with a matrix#335
De-duplicate our WinUI2/3 workflow definitions with a matrix#335michael-hawker merged 2 commits intomainfrom
Conversation
73d5a31 to
1010a60
Compare
1010a60 to
781a952
Compare
|
Hmm, so the split matrix work, but the new condition for uploading the test results failed... was a bit hard to find documentation on how those status things work. |
|
Ah, found docs here I was missing: https://docs.github.com/en/actions/learn-github-actions/contexts#steps-context I want |
Only upload test results if either test step was completed (i.e. if build fails and tests don't run, don't try and upload test results that don't exist)
781a952 to
5976599
Compare
|
Test reports are uploaded now as well: (Need to figure out later how to better bucket since we run tests twice in each environment, but that can be a separate thing. Testspace Docs here) |
Arlodotexe
left a comment
There was a problem hiding this comment.
Very neat! I don't spot any issues, good to merge 👍
|
Thanks @Arlodotexe, updated the branch protection rules to look for the new job names. So, just remember to rebase/update any PRs as you make changes. FYI @niels9001 as well for his open PR. |

Fixes #299
Changes:
Updates GitHub Actions to latest versionsUpdates to using latest revision of .NET 6 SDK automaticallyWill move other updates to another PR, we need to update the WASM head to be off .NET 5 and maybe fix some other things, same things that are tripping up the #183 PR on linux as well.