Update .NET SDK to 9.0.310 and use global.json for CI version control#779
Merged
Arlodotexe merged 2 commits intomainfrom Feb 3, 2026
Merged
Update .NET SDK to 9.0.310 and use global.json for CI version control#779Arlodotexe merged 2 commits intomainfrom
Arlodotexe merged 2 commits intomainfrom
Conversation
f6cd4cf to
b2e417c
Compare
- Update SDK version from 9.0.308 to 9.0.310 in global.json - Reorder workflow steps: checkout before setup-dotnet - Use global-json-file input for jobs with checkout - Maintain DOTNET_VERSION env var for artifact-only jobs (no checkout) This eliminates version duplication and prevents future drift between global.json and workflow definitions. Related to PR #826 which disabled rollForward to prevent SDK version mismatches.
b2e417c to
f2c2b3d
Compare
|
|
||
| env: | ||
| DOTNET_VERSION: ${{ '9.0.x' }} | ||
| DOTNET_VERSION: '9.0.310' # Only used by jobs that cannot access global.json (no checkout/artifact-only jobs) |
Member
There was a problem hiding this comment.
In these cases it's only for nuget push, eh? Is there an alternate download/install way for the nuget tool vs. dotnet we could use to avoid tracking this version here?
Member
Author
There was a problem hiding this comment.
Our options are:
- What we did here
- Hardcoding inline
- Cloning the repo so we have access to global.json
Member
Author
There was a problem hiding this comment.
Noting also duplicate with CommunityToolkit/Windows#827
michael-hawker
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The current CI setup has version specified in two places:
global.jsonwith exact version (9.0.308) androllForward: disableDOTNET_VERSIONenv var in workflow with floating version (9.0.x)This led to a previous breakage when GitHub Actions runners installed 9.0.309 while global.json expected 9.0.308 (fixed in #826 by disabling rollForward).
Solution
This PR implements single source of truth for .NET SDK version:
global-json-file: global.jsoninput foractions/setup-dotnet@v4Changes
global.json:
build.yml:
actions/checkoutnow precedesactions/setup-dotnetdotnet-version: 9.0.xtoglobal-json-file: global.jsonDOTNET_VERSIONenv var for artifact-only jobs (sign, nuget) that cannot access global.jsonBenefits
Related