Bring over Sizer controls to main repo#26
Merged
michael-hawker merged 5 commits intomainfrom Apr 19, 2023
Merged
Conversation
…te namespace to CommunityToolkit.WinUI.Controls
Removes Mouse Extension from XAML Template and does in code-behind as to remove the need to set the Cursor property directly via binding By setting the Cursor DependencyProperty we were losing our detection mechanism, now if it's set it's an explicit override, otherwise we use our logic based on Orientation property Also, switches to new CommunityToolkit.*.Extensions Dependency vs. old copies of Tree helpers Fixes some doc typos Bumps version, tested on UWP, WASDK, and Uno.UI/WASM
* Adding modern style * Address feedback * Fixing wrong state names
Arlodotexe
reviewed
Apr 19, 2023
Arlodotexe
approved these changes
Apr 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brought over from CommunityToolkit/Labs-Windows#419 (look at individual commits for bug fix/style update changes over base import)
This is the replacement for GridSplitter, so makes sense to start having this here anyway. Biggest thing missing is more E2E tests, which we need to finish building from CommunityToolkit/Labs-Windows#183 either in the Tooling Module or as a separate helper set/package.
Also Fixes CommunityToolkit/Labs-Windows#388
Should be good to go and will help with CommunityToolkit/Labs-Windows#418 next step (though we need to migrate Labs to use new dependencies once we have enough stuff ported here like Animations #25). 🎉
Glad to finally get this stuff resolved, this has been in the back of my mind for a while now. The new SizerBase is now above-and-beyond what we currently have in WCT. And even some future modern magic to from @niels9001!