Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the sbc_translation module, which provides a backend management system for SBC letter translations. It includes an XMLRPC-API for an external OWL-based translation platform, management of translators and their competencies, and automated workflows for letter translation queues. Several technical issues were identified, including potential crashes in supervisor assignment, missing module dependencies, and inefficient or incorrect computed field dependencies. Improvements were also suggested for multi-user data isolation and Odoo 18 coding standards.
ecino
force-pushed
the
dbossoku/18.0-sbc_translation
branch
from
c638597 to
0f475ad
Compare
added 3 commits
April 16, 2026 14:03
- bump version to 18.0.1.0.0 - replace legacy JS with Odoo 18 assets system - add web.assets_backend entry for translation_letter_counting_js.js
- Migrating the code for the ‘correspondence’ model and translation workflows so that they work with Odoo 18 (formerly Odoo 14) - Adjusting methods, fields, and dependencies for compatibility with Odoo 18's new APIs and conventions
ecino
force-pushed
the
dbossoku/18.0-sbc_translation
branch
from
0f475ad to
bfb4448
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.