Skip to content

oak-audit: fix finding #6 Finality proof verification is too strict #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blasrodri wants to merge 1 commit into
base: master
Choose a base branch
from
Open

oak-audit: fix finding #6 Finality proof verification is too strict #348

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions algorithms/grandpa/primitives/src/justification.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,13 +77,12 @@ where
let ancestry_chain = AncestryChain::<H>::new(&self.votes_ancestries);

match finality_grandpa::validate_commit(&self.commit, voters, &ancestry_chain) {
Ok(ref result) if !result.is_valid() =>
Err(anyhow!("invalid commit in grandpa justification: {result:?}"))?,
Ok(ref result) if result.is_valid() => {
if result.num_duplicated_precommits() > 0 ||
result.num_invalid_voters() > 0 ||
result.num_equivocations() > 0
{
Err(anyhow!("Invalid commit, found one of `duplicate precommits`, `invalid voters`, or `equivocations` {result:?}"))?
}
// TODO handle equivocations
// > The equivocations or other misbehaviors detected in the justifications must be
// >handled too but not rejecting the proof.
},
err => {
let result = err.map_err(|_| {
Expand Down