Release: merge development into beta#71
Open
github-actions[bot] wants to merge 123 commits intobetafrom
Open
Conversation
The docs/ folder already contained the full Docusaurus setup. Remove the duplicate docusaurus/ folder, switch to the company-wide reusable workflow, and update .gitignore for docs/ build artifacts.
Contributor
Author
Quality Report
Summary
PHP Quality
Vue Quality
Security
License Compliance
composer dependencies (110 total)
npm dependencies (266 total)
PHPUnit Tests
Code coverage: 0% (0 / 10 statements) Integration Tests (Newman)Newman integration tests were not enabled for this run. Generated automatically by the Quality workflow.
|
Contributor
Author
Quality Report
Summary
PHP Quality
Vue Quality
Security
License Compliance
composer dependencies (110 total)
npm dependencies (266 total)
PHPUnit Tests
Code coverage: 0% (0 / 10 statements) Integration Tests (Newman)Newman integration tests were not enabled for this run. Generated automatically by the Quality workflow.
|
Add .phpunit.cache/, coverage/, and phpmetrics/ entries to prevent generated test and quality tool artifacts from being tracked.
…Badge Replace custom table, stat cards, and CSS badge classes with shared @conduction/nextcloud-vue components following the OpenRegister pattern.
Replace custom detail layout with CnDetailPage for consistent loading, error, and stats display. Use CnStatusBadge for entity type badge.
…k and CnStatusBadge Use shared components for KPI widgets and consent status display, removing custom CSS badge classes.
Move document-creatie-sjablonen, document-signing, and register-i18n (all status: proposed) from specs/ to changes/ with proper OpenSpec change structure. Remove woo-transparency redirect (moved to OpenCatalogi). 9 reviewed specs remain in specs/.
- Move 3 proposed specs (document-creatie-sjablonen, document-signing, register-i18n) to changes/ - Add status: implemented frontmatter to woo-transparency stub - Create .openspec.yaml, proposal.md, tasks.md for each new change - Rename '## ADDED Requirements' to '## Requirements' in archive specs
All specs moved from openspec/specs/ to openspec/changes/ with proper proposal.md as the entry point. Follows the spec-driven workflow: proposal -> design -> specs -> tasks
Add ADR references to the rules section of openspec/config.yaml so that ADR constraints are injected into openspec instructions output during artifact creation.
Make ADR-011 more specific: list concrete directories to search and common duplications to prevent future utility reimplementations.
npm ci was failing in CI with 11 missing packages (pinia@3.0.4, @vue/devtools-api, @vue/devtools-kit, etc.) because a transitive peerDependency pulls in pinia 3.x that was never recorded in the lock file. Regenerated to add those entries so npm ci passes.
Add file headers, class docblocks, constructor docblocks, and per-method docblocks (short description, @param, @return) to the batch anonymization service layer and its controller to clear the remaining PHPCS doc-comment violations. Also break a few long lines and simplify two oversized `array{...}` return shapes that exceeded the 150-char hard limit.
Satisfy the Conduction NamedParametersSniff (custom rule that requires named arguments on internal function and method calls) across the batch anonymization workflow, consent flow, event listeners, and a handful of scattered service helpers. Pure mechanical fix: every flagged call site gains `paramName:` labels matching the target signature — no behavior change. Brings PHPCS to zero errors.
Genuine fixes: - WooProfileService::getProfile now reshapes the json_decoded profile into a typed array<string> instead of returning the mixed decode result. - BatchUploadService::collectFiles casts $_FILES values to their declared string/int types so the inferred shape matches the declared one. - SigningVerificationService::verifyDocument narrows the Node to File before calling getContent, which lives on File rather than Node. Targeted suppressions for known patterns: - JSONResponse::__construct status-code arg: clamped to int<400, 599> at call sites, but Psalm's stub expects a literal-int union; suppress inline matching the existing baseline pattern (6 sites). - DocuDeskEventListener instanceof checks against optional OpenRegister event classes get TypeDoesNotContainType suppressions (3 sites). - DocuDeskEventListener::logHandlerError gets UnusedParam suppressed because Psalm sees \OC::$server->get() as mixed and can't tell the params reach the logger. - CorrespondenceService::convertToDocx gets ForbiddenCode + UnusedParam suppressions (shell_exec is required to locate soffice; $pdfOptions is reserved for future use, matching the existing PHPMD suppression). Refreshed psalm-baseline.xml: removed 8 stale entries (5 InvalidArgument, 3 UndefinedInterfaceMethod, plus the now-fixed FalsableReturnStatement and UnusedReturnValue). `composer psalm` now reports zero errors.
Add folder analysis (to analyse complete dossiers)
Fix/ci errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated PR to sync development changes to beta for beta release.
Merging this PR will trigger the beta release workflow.