feat: Add CnObjectSidebar component to App.vue#99
Open
rubenvdlinde wants to merge 1 commit intodevelopmentfrom
Open
feat: Add CnObjectSidebar component to App.vue#99rubenvdlinde wants to merge 1 commit intodevelopmentfrom
rubenvdlinde wants to merge 1 commit intodevelopmentfrom
Conversation
Integrate the shared CnObjectSidebar from @conduction/nextcloud-vue into the root layout. Uses Vue.observable() for reactive state and provide/inject so any child component can control the object sidebar. Closes #98
Contributor
Quality Report
Summary
PHP Quality
Vue Quality
Security
License Compliance
composer dependencies (111 total)
npm dependencies (311 total)
PHPUnit TestsPHPUnit tests were not enabled for this run. Integration Tests (Newman)Newman integration tests were not enabled for this run. E2E Tests (Playwright)Playwright E2E tests were not enabled for this run. Generated automatically by the Quality workflow.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CnObjectSidebarfrom@conduction/nextcloud-vueinto the rootApp.vuelayoutobjectSidebarStateviaVue.observable()withprovide/injectso child components can open the shared object sidebarobjectSidebarState.activeis trueCloses #98
Test plan
npm run dev, check browser console)objectSidebarStatein a child component, setactive: truewith valid register/schema/objectId, and confirm the sidebar opensopenis set tofalseSideBarscomponent)