fix: Sidebar sub-resources, deep link dispatch, and search query#962
Open
rubenvdlinde wants to merge 3 commits intodevelopmentfrom
Open
fix: Sidebar sub-resources, deep link dispatch, and search query#962rubenvdlinde wants to merge 3 commits intodevelopmentfrom
rubenvdlinde wants to merge 3 commits intodevelopmentfrom
Conversation
- Dispatch DeepLinkRegistrationEvent in boot() so consuming apps
(Procest, Pipelinq) can register their URL patterns
- Add setVerb('comment') in NoteService — Nextcloud CommentsManager
requires a verb before saving
- Return empty array instead of 500 when user has no VTODO calendar
in TasksController::index()
- Fix search query to only include property columns that exist in
each magic table, preventing "column does not exist" errors in
UNION queries across tables with different schemas
Contributor
Quality Report
Summary
PHP Quality
Vue Quality
Security
License Compliance
composer dependencies (147 total)
npm dependencies (586 total)
PHPUnit TestsPHPUnit tests were not enabled for this run. Integration Tests (Newman)Newman integration tests were not enabled for this run. Generated automatically by the Quality workflow.
|
Contributor
Quality Report
Summary
PHP Quality
Vue Quality
Security
License Compliance
composer dependencies (147 total)
npm dependencies (595 total)
PHPUnit TestsPHPUnit tests were not enabled for this run. Integration Tests (Newman)Newman integration tests were not enabled for this run. E2E Tests (Playwright)Playwright E2E tests were not enabled for this run. Generated automatically by the Quality workflow.
|
Contributor
Quality Report
Summary
PHP Quality
Vue Quality
Security
License Compliance
composer dependencies (147 total)
npm dependencies (595 total)
PHPUnit TestsPHPUnit tests were not enabled for this run. Integration Tests (Newman)Newman integration tests were not enabled for this run. E2E Tests (Playwright)Playwright E2E tests were not enabled for this run. Generated automatically by the Quality workflow.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeepLinkRegistrationEventinboot()so consuming apps (Procest, Pipelinq) can register their URL patterns for Nextcloud unified search deep linkssetVerb('comment')inNoteService— Nextcloud'sCommentsManagerrequires a verb before saving, fixing "Actor, Object and Verb information must be provided" errorTasksController::index()column "X" does not existerrors in UNION queries across tables with different schemasTest plan