fix: Detect and sync missing columns even when schema version is unchanged#990
Open
rubenvdlinde wants to merge 3 commits intodevelopmentfrom
Open
fix: Detect and sync missing columns even when schema version is unchanged#990rubenvdlinde wants to merge 3 commits intodevelopmentfrom
rubenvdlinde wants to merge 3 commits intodevelopmentfrom
Conversation
…anged ensureTableForRegisterSchema previously skipped sync when the stored schema version matched. If columns were added to a schema after the version was stored (without a proper sync), the table would be missing columns indefinitely. Now performs a fast sanity check comparing required columns against actual table columns. If any are missing, forces a sync regardless of the version hash. Closes #974
Contributor
Quality Report
Summary
PHP Quality
Vue Quality
Security
License Compliance
composer dependencies (147 total)
npm dependencies (586 total)
PHPUnit TestsPHPUnit tests were not enabled for this run. Integration Tests (Newman)Newman integration tests were not enabled for this run. E2E Tests (Playwright)Playwright E2E tests were not enabled for this run. Generated automatically by the Quality workflow.
|
Contributor
Quality Report
Summary
PHP Quality
Vue Quality
Security
License Compliance
composer dependencies (147 total)
npm dependencies (595 total)
PHPUnit TestsPHPUnit tests were not enabled for this run. Integration Tests (Newman)Newman integration tests were not enabled for this run. E2E Tests (Playwright)Playwright E2E tests were not enabled for this run. Generated automatically by the Quality workflow.
|
Contributor
Quality Report
Summary
PHP Quality
Vue Quality
Security
License Compliance
composer dependencies (147 total)
npm dependencies (595 total)
PHPUnit TestsPHPUnit tests were not enabled for this run. Integration Tests (Newman)Newman integration tests were not enabled for this run. E2E Tests (Playwright)Playwright E2E tests were not enabled for this run. Generated automatically by the Quality workflow.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ensureTableForRegisterSchemapreviously skipped sync when the stored schema version hash matchedbuildTableColumnsFromSchemaagainst actual table columns fromgetExistingTableColumnsRoot cause
The Procest case schema (204) had
workflowTemplateandworkflowVersionproperties added after the magic table was created. The version hash was stored as "current" without the columns being created, so subsequentensureTablecalls saw no change and skipped sync.Test plan
{tags: [...]}no longer 500s)Closes #974