Improve SCSS cache directory creation and error handling#272
Draft
Improve SCSS cache directory creation and error handling#272
Conversation
…755) mkdir() was called with 0644 (a file permission), which lacks the execute bit required for directories. This made the cache directory non-traversable immediately after creation, causing is_writable() to fail and producing the misleading "permission denied" error. Replaced with wp_mkdir_p() which creates directories recursively with correct permissions (0755). Also improved error message to distinguish between directory creation failure and actual permission issues. https://claude.ai/code/session_01KsZF2sudPbLYyzoWNSjBAG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the reliability and user experience of the SCSS compiler's cache directory handling by using WordPress's built-in directory creation function and providing more informative error messages.
Key Changes
mkdir()withwp_mkdir_p(): Changed from the basic PHPmkdir()function to WordPress'swp_mkdir_p()function, which creates directories recursively and respects WordPress conventionsImplementation Details
wp_mkdir_p()function is more robust thanmkdir()as it creates parent directories if needed and handles edge cases betterhttps://claude.ai/code/session_01KsZF2sudPbLYyzoWNSjBAG