Skip to content

[NO-REF] Update Claude PR Review workflow to remove deprecated arguments#162

Merged
pedro-lb merged 1 commit intomasterfrom
update-claude-pr-review-workflow
Mar 19, 2026
Merged

[NO-REF] Update Claude PR Review workflow to remove deprecated arguments#162
pedro-lb merged 1 commit intomasterfrom
update-claude-pr-review-workflow

Conversation

@pedro-lb
Copy link
Contributor

PR Description

This PR adds the following changes:

  • Removes deprecated arguments from the Claude PR review workflow
    • hide_previous_comments
    • inline_comments

💡 note: We recently switched to a new version of the "Claude PR Review" workflow that does inline comments by default, in order to improve the code review process. Please refer to this PR for more context: https://github.com/Constructor-io/shared-claude-code-resources/pull/39

🕹 Demo

Once this is merged you should see that the "Claude PR Review" workflow no longer failing, and giving you inline reviews.

You'll also see a short summary in the code review body, with all discussions extracted as inline comments in the code.

Example:

image

@pedro-lb pedro-lb requested a review from HHHindawy as a code owner March 19, 2026 14:58
@pedro-lb pedro-lb requested review from Copilot and esezen March 19, 2026 14:58
@constructor-claude-bedrock
Copy link

Code Review Summary

This is a simple and clean maintenance PR that removes two deprecated arguments (hide_previous_comments and inline_comments) from the Claude PR Review GitHub Actions workflow. The change is minimal (2 lines removed) and aligns the workflow with the updated shared reusable workflow that now handles inline comments by default.

Detailed Feedback

  • [General] The change is correct and necessary. The deprecated with: block (along with hide_previous_comments: true) is being removed since the upstream reusable workflow (shared-claude-code-resources-public/claude-code-review.yml@main) no longer supports these arguments and handles inline commenting natively. This prevents workflow failures caused by passing unrecognized inputs.

  • [General] Pinning the reusable workflow to @main means changes in the upstream workflow are picked up automatically without requiring updates here. This is acceptable for an internal/shared workflow within the same organization, but worth keeping in mind — a breaking change upstream would immediately affect this repo. Consider tracking upstream changes via the referenced PR context.

  • [File: .github/workflows/claude-review.yml] The resulting workflow file is clean, minimal, and correct. No issues found.

Conclusion

This is a straightforward housekeeping change with no logic impact on the Android client itself. The motivation is well-documented in the PR description and the referenced upstream PR. Approved — good to merge.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository’s GitHub Actions configuration for the “Claude PR Review” reusable workflow by removing deprecated inputs so the workflow no longer fails and continues producing inline review comments via the new default behavior.

Changes:

  • Removed the deprecated hide_previous_comments input from the Claude PR review workflow invocation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@pedro-lb pedro-lb merged commit 71296d6 into master Mar 19, 2026
5 checks passed
@pedro-lb pedro-lb deleted the update-claude-pr-review-workflow branch March 19, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants