Skip to content

[NO-REF] Update Claude PR Review workflow to remove deprecated arguments#439

Merged
esezen merged 1 commit intomasterfrom
update-claude-pr-review-workflow
Mar 19, 2026
Merged

[NO-REF] Update Claude PR Review workflow to remove deprecated arguments#439
esezen merged 1 commit intomasterfrom
update-claude-pr-review-workflow

Conversation

@pedro-lb
Copy link
Contributor

PR Description

This PR adds the following changes:

  • Removes deprecated arguments from the Claude PR review workflow
    • hide_previous_comments
    • inline_comments

💡 note: We recently switched to a new version of the "Claude PR Review" workflow that does inline comments by default, in order to improve the code review process. Please refer to this PR for more context: https://github.com/Constructor-io/shared-claude-code-resources/pull/39

🕹 Demo

Once this is merged you should see that the "Claude PR Review" workflow no longer failing, and giving you inline reviews.

You'll also see a short summary in the code review body, with all discussions extracted as inline comments in the code.

Example:

image

Copilot AI review requested due to automatic review settings March 19, 2026 14:57
@esezen esezen merged commit 0426731 into master Mar 19, 2026
9 of 11 checks passed
@esezen esezen deleted the update-claude-pr-review-workflow branch March 19, 2026 14:58
@constructor-claude-bedrock
Copy link

Code Review: [NO-REF] Update Claude PR Review workflow to remove deprecated arguments

Files Reviewed: 1 file, +0/-2 lines

P1 Critical Issues (0 found)

None.

P2 Important Issues (0 found)

None.

P3 Suggestions (0 found)

None.

Strengths

This is a clean, minimal maintenance change that removes two deprecated workflow arguments (hide_previous_comments and inline_comments) from the reusable Claude PR Review workflow call. The change is well-scoped and correctly removes only the with: block (since there are now no remaining arguments to pass), leaving the secrets: inherit intact. The PR description is thorough—it links to the upstream shared workflow PR for context and includes a visual example of the improved inline comment behavior.

The resulting workflow file is concise and correct:

jobs:
  review:
    uses: Constructor-io/shared-claude-code-resources-public/.github/workflows/claude-code-review.yml@main
    secrets: inherit

Overall Assessment: APPROVED

No issues found. This is a straightforward housekeeping change aligned with the upstream workflow update.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository’s “Claude PR Review” GitHub Actions workflow to align with the newer reusable workflow version by removing deprecated inputs that were causing failures.

Changes:

  • Removed the deprecated hide_previous_comments input from the claude-review.yml reusable workflow invocation.
  • Eliminated the now-unneeded with: block in the workflow job.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment on lines 8 to 10
review:
uses: Constructor-io/shared-claude-code-resources-public/.github/workflows/claude-code-review.yml@main
with:
hide_previous_comments: true
secrets: inherit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants