[CDX-390]: update VarioationsMap type

[niizom]

This PR adds a new filter_by field for VariationsMap interface.

group_by and values fields are no longer valid and need to be updated

[Copilot]

Pull request overview

Updates the public VariationsMap TypeScript type to include a new filter_by field, and adjusts tsd fixtures for search/autocomplete responses accordingly.

Changes:

• Added FilterNode / FilterBy types and introduced filter_by on VariationsMap.
• Updated search.test-d.ts and autocomplete.test-d.ts fixtures to include filter_by.
• Minor formatting changes in ResultSources and VariationsMap type declarations.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File	Description
src/types/index.d.ts	Adds filter_by typing (and supporting types) to VariationsMap; includes minor formatting edits.
src/types/tests/search.test-d.ts	Updates the variations_map fixture to include filter_by.
src/types/tests/autocomplete.test-d.ts	Updates the variations_map fixture to include filter_by.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The new filter_by field is only set to {} here, which doesn’t actually validate the intended filter_by shape (nested and/or/not with field/value). Consider adding at least one non-empty example so tsd will catch regressions in the FilterBy/FilterNode typing.

Suggested change

	filter_by: {},
	filter_by: {
	and: [
	{
	field: 'data.availability',
	value: 'in stock',
	},
	{
	or: [
	{
	field: 'data.quantity',
	value: '>=1',
	},
	{
	field: 'data.backorderable',
	value: 'true',
	},
	],
	},
	{
	not: {
	field: 'data.discontinued',
	value: 'true',
	},
	},
	],
	},

[Copilot]

The new filter_by field is only set to {} here, which doesn’t validate the FilterBy/FilterNode structure. Add a non-empty filter_by example (e.g. a nested and/or with field and value) so this test will fail if the filter_by typing regresses.

Suggested change

	filter_by: {},
	filter_by: {
	and: [
	{
	field: 'data.availability',
	value: 'in stock',
	},
	{
	or: [
	{
	field: 'data.quantity',
	value: '10',
	},
	],
	},
	],
	},

[esezen]

@niizom thanks for working on this! I left some comments. Do you mind taking a look a the AI reviews as well?

[constructor-claude-bedrock]

Code Review

This PR updates VariationsMap with a new filter_by field, makes group_by optional, expands the Aggregation type, and properly types the response variations_map field — the changes are well-structured overall but have a few issues worth addressing.

Inline comments: 6 discussions added

Overall Assessment: ⚠️ Needs Work