Skip to content

[NO-REF] Update Claude PR Review workflow to remove deprecated arguments#182

Merged
esezen merged 1 commit intomasterfrom
update-claude-pr-review-workflow
Mar 19, 2026
Merged

[NO-REF] Update Claude PR Review workflow to remove deprecated arguments#182
esezen merged 1 commit intomasterfrom
update-claude-pr-review-workflow

Conversation

@pedro-lb
Copy link
Contributor

PR Description

This PR adds the following changes:

  • Removes deprecated arguments from the Claude PR review workflow
    • hide_previous_comments
    • inline_comments

💡 note: We recently switched to a new version of the "Claude PR Review" workflow that does inline comments by default, in order to improve the code review process. Please refer to this PR for more context: https://github.com/Constructor-io/shared-claude-code-resources/pull/39

🕹 Demo

Once this is merged you should see that the "Claude PR Review" workflow no longer failing, and giving you inline reviews.

You'll also see a short summary in the code review body, with all discussions extracted as inline comments in the code.

Example:

image

Copilot AI review requested due to automatic review settings March 19, 2026 14:57
@pedro-lb pedro-lb requested review from Mudaafi and esezen as code owners March 19, 2026 14:57
@constructor-claude-bedrock
Copy link

Code Review Summary

This is a minimal, focused maintenance PR that removes two deprecated arguments (hide_previous_comments and inline_comments) from the Claude PR Review GitHub Actions workflow (.github/workflows/claude-review.yml). The change is straightforward: the with: block and the hide_previous_comments: true entry are removed entirely, as the new version of the shared workflow handles inline comments natively and no longer supports these parameters.

Detailed Feedback

  • [File: .github/workflows/claude-review.yml] The removal is correct and clean. The diff is exactly what is needed — no leftover empty with: block, no extraneous whitespace changes. The resulting workflow correctly delegates all configuration to the reusable workflow via secrets: inherit, which is the intended pattern.

  • [General] The PR description is clear and includes a helpful reference to the upstream shared-resources PR for context. No functional Java code is changed, so there is no risk of regression in the library itself.

  • [General] One minor observation: the PR description mentions removing both hide_previous_comments and inline_comments as deprecated arguments. However, the actual diff only shows the removal of the with: block containing hide_previous_comments: true. There is no evidence of a separate inline_comments argument having existed in this file. This is likely a slight inaccuracy in the description (the inline_comments argument may have been removed previously or may not have existed in this repo's copy of the workflow), but worth confirming that both deprecated arguments have been fully handled as intended.

Conclusion

The change is correct, minimal, and low-risk. The workflow file is left in a clean and valid state. Approved pending the minor description clarification above.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository’s “Claude PR Review” GitHub Actions workflow to align with the newer shared workflow interface by removing deprecated inputs, preventing workflow failures and ensuring inline reviews work as intended.

Changes:

  • Removed the deprecated hide_previous_comments workflow input from the reusable workflow invocation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment on lines 8 to 10
review:
uses: Constructor-io/shared-claude-code-resources-public/.github/workflows/claude-code-review.yml@main
with:
hide_previous_comments: true
secrets: inherit
@esezen esezen merged commit 12edfb9 into master Mar 19, 2026
9 checks passed
@esezen esezen deleted the update-claude-pr-review-workflow branch March 19, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants