Fix update and update-in for higher arities#534
Open
jeroenvandijk wants to merge 1 commit intoConvex-Dev:developfrom
Open
Fix update and update-in for higher arities#534jeroenvandijk wants to merge 1 commit intoConvex-Dev:developfrom
jeroenvandijk wants to merge 1 commit intoConvex-Dev:developfrom
Conversation
Member
|
Just to be clear, this fix still very much on cards but need to be vary careful about convex.core changes on Protonet :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #533
Added unit tests and fixed the implementation.
The GenesisTest is now failing. I guess this is expected when changing core resources?