Skip to content

Updated config space paper plots#185

Open
LisaGoh wants to merge 3 commits intodevelopfrom
config_space_plots
Open

Updated config space paper plots#185
LisaGoh wants to merge 3 commits intodevelopfrom
config_space_plots

Conversation

@LisaGoh
Copy link
Copy Markdown
Member

@LisaGoh LisaGoh commented Mar 26, 2026

Hello, I cleaned up and updated all the notebooks to create the plots in the configuration space paper!

@LisaGoh LisaGoh requested review from cailmdaley and sachaguer March 26, 2026 12:47
@LisaGoh LisaGoh self-assigned this Mar 26, 2026
@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@cailmdaley
Copy link
Copy Markdown
Collaborator

nice! about to review but i wanted to ask if you'd be interested in doing something like what was done in the SPT-3G D1 paper on the diagonal? both pretty and more information, will make it more likely that people use our plots. it's implemented in Karim's fork of getdist (example notebook here. happy to prototype it in order to not make more work for you

Screenshot 2026-03-27 at 19 01 20

@cailmdaley
Copy link
Copy Markdown
Collaborator

Looks great Lisa, nice cleanup! Two small things I noticed:

1. Whisker plot separator loop (S8_om_sigma8_whisker.ipynb) — the for ax in axs: loop on the separation lines doesn't use ax; it draws on ax1/ax2/ax3 directly, so each line gets drawn 3× redundantly. Doesn't affect the output, just a no-op loop.

2. ifelif in get_chi2.ipynb — the chain-loading cell has:

if 'nautilus' in root:
    samples = ...
if 'mh' in root:       # ← should be elif
    ...
else:
    samples = ...       # overwrites nautilus case

For a nautilus root, the else branch (polychord format) runs after the nautilus branch, overwriting it. contours.ipynb has this correct with elif. Dormant since the getdist files already exist on disk, but would bite on a fresh rerun.

@LisaGoh
Copy link
Copy Markdown
Member Author

LisaGoh commented Mar 31, 2026

Thank you! Okie will look into adding the separate 1D posteriors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants