Replace look with lookText' in controller modules#1679
Open
Purplegaze wants to merge 10 commits intoCourseography:masterfrom
Open
Replace look with lookText' in controller modules#1679Purplegaze wants to merge 10 commits intoCourseography:masterfrom
Purplegaze wants to merge 10 commits intoCourseography:masterfrom
Conversation
… into overloadedstrings-cleanup
… into overloadedstrings-cleanup
Pull Request Test Coverage Report for Build f62b14df-2719-4a15-a9db-973c1de81d2cDetails
💛 - Coveralls |
Contributor
david-yz-liu
left a comment
There was a problem hiding this comment.
Good work, I just left one inline comment. Please also be sure to update the changelog with a new entry for this refactoring.
| writeActiveGraphImage :: T.Text -> Handle -> IO () | ||
| writeActiveGraphImage graphInfo svgHandle = do | ||
| let graphInfoMap = fromMaybe M.empty $ decode $ fromStrict $ BC.pack graphInfo :: M.Map T.Text T.Text | ||
| let graphInfoMap = fromMaybe M.empty $ decode $ fromStrict $ TE.encodeUtf8 graphInfo :: M.Map T.Text T.Text |
Contributor
There was a problem hiding this comment.
Right now we're using the Aeson decode function, but you should be able to instead use decodeStrictText to simplify the conversions here.
I don't think the encodeUtf8 call is necessary, as the Happstack docs say that the lookText function assumed the data is UTF-8 encoded already.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Replaces
lookwithlookTextinControllers/GraphandControllers/Timetable.BC.packis replaced withTE.encodeUtf8in a related function; this is backwards compatible sinceBC.packworks on ASCII and all ASCII is valid UTF8....
Screenshots of your changes (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)