Update EventMonitor logging for continuous and night time only capture modes#813
Merged
dvida merged 6 commits intoCroatianMeteorNetwork:prereleasefrom Mar 9, 2026
Conversation
Contributor
Author
|
On test on au001a |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates EventMonitor to correctly handle continuous and night-time-only capture modes when logging capture start times and durations. Previously, EventMonitor was unaware of continuous capture mode, leading to incorrect logging.
Changes:
- Modified
captureDuration()to acceptcontinuous_captureandsun_angleparameters to specify different sun angle thresholds - Updated EventMonitor logging to distinguish between continuous and night-time-only capture modes
- Fixed requirements.txt for pip compatibility by removing deprecated egg syntax from git URL
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 12 comments.
| File | Description |
|---|---|
| requirements.txt | Simplified imreg_dft git URL by removing deprecated #egg= syntax and version constraint for modern pip compatibility |
| RMS/CaptureDuration.py | Added continuous_capture and sun_angle keyword parameters; added test/demo code in __main__ block; includes new imports and constants |
| RMS/EventMonitor.py | Updated captureDuration() call to pass continuous_capture parameter; improved logging format and added messages for continuous capture mode; added unused numpy import |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dvida
added a commit
that referenced
this pull request
Mar 10, 2026
…_and_night_time Update EventMonitor logging for continuous and night time only capture modes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EventMonitor logs the start time, time until and duration of capture. If continuous capture mode is selected, this logging would be wrong, because EventMonitor is not aware of continuous capture mode.
This PR adds keyword arguments to captureDuration so that the capture mode can be specified, or a specific sun angle on the horizon.
It makes small changes to the logging, for readability.
It modifies requirements.txt for compatibility with the latest version of pip.