Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/node/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"@typescript-eslint/eslint-plugin": "^6.7.4",
"@typescript-eslint/parser": "^6.7.4",
"@vercel/ncc": "^0.38.1",
"eslint": "^8.50.0",
"eslint": "^9.26.0",
"eslint-config-prettier": "^9.0.0",
"eslint-plugin-prettier": "^5.0.0",
"prettier": "^3.0.3",
Expand Down
2 changes: 1 addition & 1 deletion backend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@
"copyfiles": "2.4.1",
"cross-env": "7.0.2",
"deep-object-diff": "^1.1.9",
"eslint": "^8.12.0",
"eslint": "^9.26.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint 9 requires @typescript-eslint v8, but v5/v6 remain

High Severity

Upgrading eslint from v8 to v9.26.0 without updating @typescript-eslint/eslint-plugin and @typescript-eslint/parser creates a peer dependency incompatibility. ESLint 9.x requires @typescript-eslint/* v8+, but the packages remain at v5.x (backend, services) and v6.x (github actions). This will cause linting to fail or behave incorrectly since the typescript-eslint packages don't support ESLint 9's APIs and flat config system.

Additional Locations (2)

Fix in Cursor Fix in Web

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint 9 incompatible with eslint-config-airbnb packages

High Severity

The eslint-config-airbnb-base: ^15.0.0 and eslint-config-airbnb-typescript: ^16.1.4 packages do not support ESLint 9.x. These configs use the legacy eslintrc format and rules that are incompatible with ESLint 9's new configuration system. The Airbnb team has not released ESLint 9-compatible versions, so linting in the backend will fail even after addressing the @typescript-eslint incompatibility.

Fix in Cursor Fix in Web

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint 9 won't find legacy .eslintrc config files

High Severity

ESLint 9 uses flat config (eslint.config.js) by default and no longer automatically discovers .eslintrc.* files. The codebase has backend/.eslintrc.js, services/.eslintrc.cjs, and .github/actions/node/.eslintrc.cjs but no flat config files anywhere. Running eslint . (the backend lint script) will fail because ESLint 9 can't find a config. No migration to flat config or ESLINT_USE_FLAT_CONFIG=false workaround was added.

Additional Locations (2)

Fix in Cursor Fix in Web

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint 9 incompatible with existing plugin ecosystem

High Severity

Bumping eslint from v8 to v9 is a major version upgrade with breaking changes, but none of the dependent plugins or configs were updated. @typescript-eslint/eslint-plugin v5 (backend/services) and v6 (.github/actions/node) only support ESLint ^6 || ^7 || ^8. Similarly, eslint-config-airbnb-base v15, eslint-config-airbnb-typescript v16, and eslint-plugin-import v2.29.1 don't support ESLint 9. The project also has no eslint.config.js (flat config), which ESLint 9 requires by default, and multiple service lint scripts use the removed --ext CLI flag. This will break linting across the entire project.

Additional Locations (2)

Fix in Cursor Fix in Web

"eslint-config-airbnb-base": "^15.0.0",
"eslint-config-airbnb-typescript": "^16.1.4",
"eslint-config-prettier": "^8.5.0",
Expand Down
Loading
Loading