-
Notifications
You must be signed in to change notification settings - Fork 727
chore: remove repos from integrations.settings column for github and github-nango integrations (CM-1005) #3882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
themarolt
wants to merge
6
commits into
main
Choose a base branch
from
fixes-and-repos-removal-CM-1005
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+527
−277
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
fbe4d69
chore: remove repos from integrations.settings since we have them in …
themarolt 2fe0a78
fix: fixed removal of repos from settings for old github integration …
themarolt 49592d2
fix: some fixes and script improvement
themarolt 01fecfc
fix: forkedFrom for legacy github integration
themarolt ee2657f
fix: trigger ws event later in the order
themarolt d3f6b90
fix: migration fix and cleanup
themarolt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Empty file.
30 changes: 30 additions & 0 deletions
30
backend/src/database/migrations/V1772043927__removeReposFromGithubSettings.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| -- Backup settings before any modifications | ||
| CREATE TABLE integration.integrations_settings_backup_02_28_2026 AS | ||
| SELECT id, settings FROM integrations; | ||
|
|
||
| -- Strip repos from orgs in settings for github and github-nango integrations | ||
| -- Repos now live in public.repositories table and are populated into API responses | ||
| -- via the compatibility layer in integrationRepository._populateRelations | ||
| UPDATE integrations | ||
| SET settings = jsonb_set( | ||
| settings, | ||
| '{orgs}', | ||
| ( | ||
| SELECT coalesce(jsonb_agg( | ||
| org - 'repos' | ||
| ), '[]'::jsonb) | ||
| FROM jsonb_array_elements(settings->'orgs') org | ||
| ) | ||
| ) | ||
| WHERE platform IN ('github', 'github-nango') | ||
| AND settings->'orgs' IS NOT NULL | ||
| AND "deletedAt" IS NULL | ||
| AND status != 'mapping'; | ||
|
|
||
| -- Also clean up top-level repos/unavailableRepos if present | ||
| UPDATE integrations | ||
| SET settings = settings - 'repos' - 'unavailableRepos' | ||
| WHERE platform IN ('github', 'github-nango') | ||
| AND (settings ? 'repos' OR settings ? 'unavailableRepos') | ||
| AND "deletedAt" IS NULL | ||
| AND status != 'mapping'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicated repo-population logic across two layers
Low Severity
_populateRelationsinintegrationRepository.tsandpopulateGithubSettingsWithReposinrepositories/index.tscontain nearly identical logic: query repos frompublic.repositories, group by owner, and merge intosettings.orgs[].repos. They differ only in ORM (Sequelize vs pg-promise) and in whether legacy keys are stripped. This duplication risks future divergence — a bug fix or schema change applied to one but not the other.Additional Locations (1)
services/libs/data-access-layer/src/repositories/index.ts#L605-L636