adding and adjusting typehints, removing unused check_interval arguments, removing redundant replace_data method, adding delete_rows method#54
Open
AlePiccin wants to merge 14 commits intoCrystalWindSnake:mainfrom
Conversation
…e check_interval Co-authored-by: AlePiccin <149101764+AlePiccin@users.noreply.github.com>
…dd missing return types Co-authored-by: AlePiccin <149101764+AlePiccin@users.noreply.github.com>
Co-authored-by: AlePiccin <149101764+AlePiccin@users.noreply.github.com>
…-methods Add missing type hints, new methods, and modernize typing across codebase
Co-authored-by: AlePiccin <149101764+AlePiccin@users.noreply.github.com>
Co-authored-by: AlePiccin <149101764+AlePiccin@users.noreply.github.com>
Bump requires-python to >=3.10
Owner
|
@copilot We can't change the Python version requirement for this project; we must support Python 3.9. |
…me type union in utils.py Co-authored-by: AlePiccin <149101764+AlePiccin@users.noreply.github.com>
…emove from __future__ import annotations Co-authored-by: AlePiccin <149101764+AlePiccin@users.noreply.github.com>
Co-authored-by: AlePiccin <149101764+AlePiccin@users.noreply.github.com>
…hon-3-9 Standardize type notation: replace `X | Y` with `Union`/`Optional`, remove `from __future__ import annotations`
Contributor
Author
|
@CrystalWindSnake could you review this please? |
Owner
Sure, let me take a look. |
Owner
There was a problem hiding this comment.
@copilot Why are the test methods being removed?
| async def get_selected_data( | ||
| self, *, timeout: float = 1, check_interval: float = 0.01 | ||
| ) -> List[Dict]: | ||
| def delete_rows( |
Owner
There was a problem hiding this comment.
@copilot Should add tests for this method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adding and adjusting typehints, removing unused check_interval arguments, removing redundant replace_data method, adding delete_rows method