Open
Conversation
Contributor
Author
|
basic fix |
[WIP] Add hyperlink to download the latest version
Co-authored-by: ubden <44896964+ubden@users.noreply.github.com>
…nfig Co-authored-by: ubden <44896964+ubden@users.noreply.github.com>
…ssue Fix: extra_inventory_items written as object instead of array in SmokeAPI config
Add global.json for SDK resolution with .NET 8+
Agent-Logs-Url: https://github.com/ubden/CreamApi-CreamInstaller/sessions/dcd61999-e89a-498d-9245-db51edac20e0 Co-authored-by: ubden <44896964+ubden@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ubden/CreamApi-CreamInstaller/sessions/4330adfa-3a87-42b3-9d87-6b672344e50a Co-authored-by: ubden <44896964+ubden@users.noreply.github.com>
docs: Add Wikipedia antivirus reference to false-positive warning section
There was a problem hiding this comment.
Pull request overview
This PR updates repository documentation and build tooling, adjusts SmokeAPI configuration generation output, and removes GitHub Actions automation.
Changes:
- Expanded
README.mdwith disclaimer content and added “Building from Source” instructions. - Added
global.jsonto pin the .NET SDK used for builds. - Updated SmokeAPI config generation to emit
extra_inventory_itemsas an empty array ([]) instead of an empty object ({}). - Removed all GitHub Actions workflows (CI build/test, Pages deploy, and release deletion).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Adds disclaimer/donation/abuse-report sections and build-from-source instructions. |
| global.json | Pins the .NET SDK version/roll-forward behavior for consistent builds. |
| CreamInstaller/Resources/SmokeAPI.cs | Changes generated JSON for extra_inventory_items to []. |
| .github/workflows/test.yml | Removed CI workflow that built/tested on pushes/PRs. |
| .github/workflows/jekyll-gh-pages.yml | Removed GitHub Pages deployment workflow. |
| .github/workflows/delete_releases.yml | Removed manual workflow for deleting older releases/tags. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ### CreamInstaller: Automatic DLC Unlocker Installer & Configuration Generator | ||
|
|
||
| ##DONATE | ||
| # ⚠️ Disclaimer (Read before installation and Follow Us on Github !) |
There was a problem hiding this comment.
The heading uses "Github"; the product name is "GitHub" (capital H). Consider updating the wording to match GitHub’s official capitalization.
Suggested change
| # ⚠️ Disclaimer (Read before installation and Follow Us on Github !) | |
| # ⚠️ Disclaimer (Read before installation and Follow Us on GitHub !) |
Comment on lines
+94
to
+97
| 1. [.NET 8 SDK](https://dotnet.microsoft.com/en-us/download/dotnet/8.0) or later | ||
| 2. Visual Studio 2022 (or later) with .NET desktop development workload, or Visual Studio Code with C# extension | ||
|
|
||
| **Note:** While the application targets .NET 7, you can build it with .NET 8 SDK or later. The `global.json` file ensures SDK compatibility. |
There was a problem hiding this comment.
The build instructions say ".NET 8 SDK ... or later", but the newly added global.json pins the SDK to 8.0.100 with rollForward set to latestMinor (won’t roll to a newer major SDK like 9/10). Either adjust the wording (e.g., require .NET 8.x) or loosen global.json rollForward to match the documented “or later” behavior.
Suggested change
| 1. [.NET 8 SDK](https://dotnet.microsoft.com/en-us/download/dotnet/8.0) or later | |
| 2. Visual Studio 2022 (or later) with .NET desktop development workload, or Visual Studio Code with C# extension | |
| **Note:** While the application targets .NET 7, you can build it with .NET 8 SDK or later. The `global.json` file ensures SDK compatibility. | |
| 1. [.NET 8 SDK](https://dotnet.microsoft.com/en-us/download/dotnet/8.0) (8.x) | |
| 2. Visual Studio 2022 (or later) with .NET desktop development workload, or Visual Studio Code with C# extension | |
| **Note:** While the application targets .NET 7, you should build it with a .NET 8 SDK (8.x). The `global.json` file ensures SDK compatibility within the .NET 8 SDK feature band. |
Comment on lines
+1
to
+5
| ### CreamInstaller: Automatic DLC Unlocker Installer & Configuration Generator | ||
|
|
||
| ##DONATE | ||
| # ⚠️ Disclaimer (Read before installation and Follow Us on Github !) | ||
|
|
||
| > **This software is an open-source project developed for the community and is not affiliated with any organization or institution.** |
There was a problem hiding this comment.
This PR is titled "Update README.md", but it also adds a global.json SDK pin, changes C# config generation, and removes GitHub Actions workflows. If that’s intentional, consider updating the PR title/description so reviewers understand it changes build tooling, runtime output, and CI/automation.
| { | ||
| "sdk": { | ||
| "version": "8.0.100", | ||
| "rollForward": "latestMinor", |
There was a problem hiding this comment.
With sdk.version pinned to 8.0.100, rollForward: "latestMinor" will not roll forward to a newer major SDK (e.g., 9/10). If the intent is to allow building with newer SDK majors, consider using a rollForward option that allows major roll-forward, or otherwise update the README to clearly require .NET 8.x specifically.
Suggested change
| "rollForward": "latestMinor", | |
| "rollForward": "latestMajor", |
Comment on lines
+92
to
+96
| #### Building from Source: | ||
| To build the project from source code, you need: | ||
| 1. [.NET 8 SDK](https://dotnet.microsoft.com/en-us/download/dotnet/8.0) or later | ||
| 2. Visual Studio 2022 (or later) with .NET desktop development workload, or Visual Studio Code with C# extension | ||
|
|
There was a problem hiding this comment.
This PR removes all GitHub Actions workflows (the .github/workflows directory no longer exists), so there will be no CI build/test validation on PRs. If that’s not intentional, consider re-adding a minimal workflow that at least runs dotnet restore/dotnet build (and tests if any) on pull_request.
…omments Agent-Logs-Url: https://github.com/ubden/CreamApi-CreamInstaller/sessions/8e5d9ac7-4144-49da-ac9b-411226fbdc45 Co-authored-by: ubden <44896964+ubden@users.noreply.github.com>
…ion fix Agent-Logs-Url: https://github.com/ubden/CreamApi-CreamInstaller/sessions/8e5d9ac7-4144-49da-ac9b-411226fbdc45 Co-authored-by: ubden <44896964+ubden@users.noreply.github.com>
…rmance-security fix: bugs, performance, security, and AV false-positive annotations
…ve UI components - Updated .NET SDK version to 9.0 in global.json and project files. - Added new entries to .gitignore for DLL files. - Enhanced README with community support links and installation instructions. - Improved UI elements in forms for better user experience, including dark mode support. - Added log export functionality in the installation form. - Implemented search/filter functionality in the selection form. - Updated various components to use new theming and styling conventions.
Removed community support section from README.
- Updated build.yml and release.yml to include FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 environment variable for improved compatibility with Node.js 24.
- Updated build workflow to change code formatting severity from 'warn' to 'info'. - Modified various components to use more explicit checks (e.g., replacing 'Any()' with 'Count > 0'). - Enhanced readability in string index operations by using single quotes for characters. - Ensured list conversions are explicitly handled in LINQ queries for better clarity.
- Add NoWarn (CA1806/CA1860/CA1865/CA2263/CA1861/CA1872) to csproj - Add TreatWarningsAsErrors=false to csproj and CI workflow - Remove dotnet format --verify-no-changes (was causing exit code 1) - Seal DarkButton class (CA1852) - Make GatherTreeNodes static (CA1822) Made-with: Cursor
- CustomTreeView: replace invisible dark colors with bright amber/sky-blue/green - ThemeManager: brighter TextDisabled, CheckBox EnabledChanged hook for ForeColor - ThemeManager: fix GroupBox paint to not cover header-area checkboxes - CustomForm: replace emoji with ASCII markers (WinForms GDI+ compatibility) Made-with: Cursor
This reverts commit be488f2.
This reverts commit b2200c3.
…ix icon handle leak - SteamCMD.cs: use GetAwaiter().GetResult() instead of .Wait() in Dispose() to avoid potential deadlocks on synchronization contexts - SteamStore.cs: replace Thread.Sleep(1000) with await Task.Delay(1000) in async retry loop to avoid blocking a thread-pool thread - InstallForm.cs: replace Thread.Sleep(1) with await Task.Delay(1) in async methods to yield correctly to the scheduler - SelectForm.cs: replace Thread.Sleep(200) with await Task.Delay(200) inside async Task.Run lambda for proper async behavior - EpicStore.cs: add `using` on HttpResponseMessage to ensure disposal on all code paths including exceptions - IconGrabber.cs: fix unmanaged GDI icon handle leak — call DestroyIcon() via P/Invoke after cloning the Icon, preventing accumulation in system memory 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
perf: replace blocking Thread.Sleep/.Wait() with async equivalents and fix GDI icon handle leak
Contributor
Author
|
OK |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.