Open
Conversation
jayvdb
commented
May 2, 2022
| add_executable(websockettest test/websocket.cpp) | ||
| target_link_libraries(websockettest mist) | ||
|
|
||
| # logtest & jsontest hangs |
Author
There was a problem hiding this comment.
This was curious. The CI isnt very effective if most of the tests are not working.
Are these tests working for other people?
Should we create issues about these tests?
Contributor
There was a problem hiding this comment.
Most test binaries were made to allow scripted batch testing (and thus operate on stdin/stdout). @stronk-dev did some work last year on these scripts - it may be worthwhile to dig that work up again and see how much test coverage it all provides. 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sits on top of #34
Here is what it looks like https://github.com/jayvdb/mistserver/actions/runs/2260698793