[SPIKE] New manifest to help build predictable URLs#213
Draft
alexluckett wants to merge 3 commits intomainfrom
Draft
[SPIKE] New manifest to help build predictable URLs#213alexluckett wants to merge 3 commits intomainfrom
alexluckett wants to merge 3 commits intomainfrom
Conversation
…tion from the plugin
5f86511 to
65c2563
Compare
d1798a9 to
51e2ed1
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Context
When a user uploads a file, we poll the backend to check the file upload status at
/{prefix}/upload-status/{uploadId}. However,prefixis not known to the client-side JS and may even be missing if a developer doesn't register forms-engine-plugin with a prefix.Problem
[ This is no longer actually a problem as I fixed the immediate issue in main, however my fix is brittle ]
Currently, our file-upload JS breaks if the plugin doesn't have a prefix. So we need better logic to determine the "base path" of the plugin.
Solution
Introduce a new manifest plugin that sits on a fixed URL, giving client-side JS a predictable path to build URLs by using the config it returns.
buildUploadStatusUrlshows why this is useful.Pros:
Cons:
engineare passed through as plugin registration options. Slightly unusual, although not major.