Skip to content

Accessibility Issue Fix #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Scullyon wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Accessibility Issue Fix #298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b6fa42
Fixing accessibility issue on file upload for screen readers DAC_Stat…
Scullyon Jan 16, 2026
f213968
Merge branch 'main' into feat/DF-784-accessibility
Scullyon Feb 2, 2026
8187ac7
Fixing test
Scullyon Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/server/plugins/engine/views/components/fileuploadfield.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,10 @@
<div id="uploadedFilesContainer">
<h2 class="govuk-heading-m">Uploaded files</h2>
{% if upload.count %}
<p class="govuk-body">{{upload.count}} file{{ "s" if upload.count > 1}} uploaded</p>
<p class="govuk-body" role="alert">{{upload.count}} file{{ "s" if upload.count > 1}} uploaded</p>
<p class="govuk-body">
</p>

<div class="govuk-visually-hidden" aria-live="polite" id="statusInformation">
{{upload.count}} file{{ "s" if upload.count > 1}} uploaded
</div>

{% if upload.summaryList.rows | length %}
{{ govukSummaryList(upload.summaryList) }}
{% endif %}
Expand Down
9 changes: 8 additions & 1 deletion test/form/file-upload.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,14 @@ describe('File upload POST tests', () => {

expect(response.statusCode).toBe(StatusCodes.OK)

const $errorSummary = container.getByRole('alert')
const $errorSummary = container
.getAllByRole('alert')
.find((el) => within(el).queryAllByRole('listitem').length)

if (!$errorSummary) {
throw new Error('Unable to find error summary')
}

const $errorItems = within($errorSummary).getAllByRole('listitem')

const $heading = within($errorSummary).getByRole('heading', {
Expand Down
Loading