chore(DF-859): migrate eslint to v9 flat config and fix vulnerabilites#322
Merged
jbarnsley10 merged 4 commits intomainfrom Mar 4, 2026
Merged
chore(DF-859): migrate eslint to v9 flat config and fix vulnerabilites#322jbarnsley10 merged 4 commits intomainfrom
jbarnsley10 merged 4 commits intomainfrom
Conversation
|
mokhld
commented
Mar 3, 2026
| "type": "git", | ||
| "url": "git+https://github.com/DEFRA/forms-engine-plugin.git" | ||
| }, | ||
| "overrides": { |
Contributor
Author
There was a problem hiding this comment.
The minimatch vulnerability (<=3.1.3, high severity, ReDoS) comes from serve-handler@6.1.6 pinning minimatch@3.0.4, which is a transitive dependency of @docusaurus/core. There’s an open PR to fix this upstream (vercel/serve-handler#228). A blanket override breaks Jest’s coverage instrumentation (test-exclude expects CJS minimatch), so we’ve used a scoped override targeting only serve-handler’s minimatch to 3.1.5 (the latest safe 3.x patch) which resolves all three CVEs without impacting tests.
alexluckett
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Proposed change
Jira ticket:
Type of change
Checklist
README.mdanddocs/*(where appropriate, e.g. new features).npm run test).npm run lint).npm run format).