Skip to content

chore(DF-859): migrate eslint to v9 flat config and fix vulnerabilites#322

Merged
jbarnsley10 merged 4 commits intomainfrom
chore/df-859-eslint9-migration
Mar 4, 2026
Merged

chore(DF-859): migrate eslint to v9 flat config and fix vulnerabilites#322
jbarnsley10 merged 4 commits intomainfrom
chore/df-859-eslint9-migration

Conversation

@mokhld
Copy link
Contributor

@mokhld mokhld commented Mar 2, 2026

Proposed change

Jira ticket:

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Misc. (documentation, build updates, etc)

Checklist

  • You have executed this code locally and it performs as expected.
  • You have added tests to verify your code works.
  • You have added code comments and JSDoc, where appropriate.
  • There is no commented-out code.
  • You have added developer docs in README.md and docs/* (where appropriate, e.g. new features).
  • The tests are passing (npm run test).
  • The linting checks are passing (npm run lint).
  • The code has been formatted (npm run format).

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 3, 2026

@mokhld mokhld marked this pull request as ready for review March 3, 2026 09:56
"type": "git",
"url": "git+https://github.com/DEFRA/forms-engine-plugin.git"
},
"overrides": {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The minimatch vulnerability (<=3.1.3, high severity, ReDoS) comes from serve-handler@6.1.6 pinning minimatch@3.0.4, which is a transitive dependency of @docusaurus/core. There’s an open PR to fix this upstream (vercel/serve-handler#228). A blanket override breaks Jest’s coverage instrumentation (test-exclude expects CJS minimatch), so we’ve used a scoped override targeting only serve-handler’s minimatch to 3.1.5 (the latest safe 3.x patch) which resolves all three CVEs without impacting tests.

Copy link
Contributor

@jbarnsley10 jbarnsley10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbarnsley10 jbarnsley10 merged commit 34d9a3a into main Mar 4, 2026
27 checks passed
@jbarnsley10 jbarnsley10 deleted the chore/df-859-eslint9-migration branch March 4, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants