feat: add Raiffeisen as full bank asset (EUR + CHF)#3301
Draft
TaprootFreak wants to merge 5 commits intodevelopfrom
Draft
feat: add Raiffeisen as full bank asset (EUR + CHF)#3301TaprootFreak wants to merge 5 commits intodevelopfrom
TaprootFreak wants to merge 5 commits intodevelopfrom
Conversation
Add RAIFFEISEN to Blockchain enum, wire up blockchainToBankName mapping, extend pendingInputAmount, create Raiffeisen/EUR and Raiffeisen/CHF seed assets (IDs 410/411), and fix bank entries 12/13 from misnamed "Maerki Baumann" to "Raiffeisen" with correct asset references.
BIC OLKILUL1 and IBAN LU11... belong to Olkypay, not Maerki Baumann. Link to existing Olkypay/EUR asset (ID 269).
Raiffeisen bank transactions were not matched in the pending input amount calculation, causing buyCrypto inputs via Raiffeisen to be invisible in the FinancialDataLog. This led to a double-negative balance impact when outputAmount was set (buyCryptoPass liability added without corresponding input offset). Affected: 3 transactions totaling 416,500 EUR since Feb 11.
…ed IDs - Add Blockchain.RAIFFEISEN to pendingInputAmount in BankTxRepeat and BankTxReturn entities (same issue as BuyCrypto) - Add migration to create Raiffeisen EUR/CHF assets (IDs 420/421) and link them to bank records 12/13 - Fix seed CSVs: asset IDs 410/411 were already taken (Citrea), use 420/421 instead
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| @@ -0,0 +1,37 @@ | |||
| const { MigrationInterface, QueryRunner } = require("typeorm"); | |||
| @@ -0,0 +1,37 @@ | |||
| const { MigrationInterface, QueryRunner } = require("typeorm"); | |||
Bank 14 does not exist in the production database and is a duplicate of bank 4 (same Olkypay IBAN LU116060002000005040).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RAIFFEISENtoBlockchainenum and all required{ [b in Blockchain]: ... }mappingsblockchainToBankName→IbanBankName.RAIFFEISENand extendpendingInputAmountswitchRaiffeisen/EUR(ID 410) andRaiffeisen/CHF(ID 411) seed assetsTest plan
yarn lintpassesyarn buildpassesyarn testpasses (61/61 suites, 826/826 tests)isBankMatchingresolves Raiffeisen IBAN correctly