fix: include LICENSE file in dirac-common sdist and wheel #8450
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use hatchling's force-include to pull the root LICENSE into the dirac-common sdist. The wheel built from the sdist then auto-discovers the LICENSE and places it in .dist-info/licenses/.
Contributor
|
Same comment: DIRACGrid/diracx#776 (review) |
Member
Author
|
It isn't needed as it's auto-discovered from the sdist while building the wheel. |
aldbr
approved these changes
Feb 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
dirac-commonsub-package was missing the LICENSE file in published sdists and wheels because hatchling only auto-discovers license files in the package's own directory, not the monorepo root[tool.hatch.build.targets.sdist.force-include]todirac-common/pyproject.tomlto pull the rootLICENSEinto the sdist.dist-info/licenses/