Skip to content

Improvement: avoid segfault when passing a nullptr to t8_forest_element_face_neighbor #2214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dutkalex wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Improvement: avoid segfault when passing a nullptr to t8_forest_element_face_neighbor #2214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef634b7
Add null pointer case
dutkalex Mar 6, 2026
0ac3bae
Update documentation
dutkalex Mar 6, 2026
e55d09e
indent
dutkalex Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/t8_forest/t8_forest.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1466,6 +1466,11 @@ t8_gloidx_t
t8_forest_element_face_neighbor (t8_forest_t forest, t8_locidx_t ltreeid, const t8_element_t *elem, t8_element_t *neigh,
t8_eclass_t neigh_eclass, int face, int *neigh_face)
{
int dummy = 0;
if (neigh_face == nullptr) {
neigh_face = &dummy;
}

/* Get a pointer to the tree to read its element class */
const t8_tree_t tree = t8_forest_get_tree (forest, ltreeid);
const t8_eclass_t eclass = tree->eclass;
Expand Down
2 changes: 1 addition & 1 deletion src/t8_forest/t8_forest_general.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -861,7 +861,7 @@ t8_forest_element_neighbor_eclass (t8_forest_t forest, t8_locidx_t ltreeid, cons
* the data could be modified arbitrarily.
* \param [in] neigh_eclass The eclass of \a neigh.
* \param [in] face The number of the face along which the neighbor should be constructed.
* \param [out] neigh_face The number of the face viewed from perspective of \a neigh.
* \param [out] neigh_face The number of the face viewed from perspective of \a neigh. Can be nullptr.
* \return The global tree-id of the tree in which \a neigh is in.
* -1 if there exists no neighbor across that face.
*/
Expand Down
Loading