Bugfix: CAD attributes not available to t8_geometry_cad.cxx#2223
Open
saustinp wants to merge 1 commit intoDLR-AMR:mainfrom
Open
Bugfix: CAD attributes not available to t8_geometry_cad.cxx#2223saustinp wants to merge 1 commit intoDLR-AMR:mainfrom
saustinp wants to merge 1 commit intoDLR-AMR:mainfrom
Conversation
…8_geometry_cad.cxx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes here:
Added private header to src/t8_geometry/t8_geometry_implementations/t8_geometry_cad.cxx. Previously, this file required a public header, t8_geometry_cad.hxx, for T8_CMESH_CAD_EDGE_ATTRIBUTE_KEY and T8_CMESH_CAD_FACE_ATTRIBUTE_KEY. However, the header file transitively included a private header which was not available after building, which broke compilation of programs using this feature, for example t8_features_curved_meshes.cxx.
Now, src/t8_geometry/t8_geometry_implementations/t8_geometry_cad.cxx directly includes the private header file, bypassing t8_geometry_cad.hxx for these attributes. Fixes #2220.
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
scripts/internal/find_all_source_files.shto check the indentation of these files.License
doc/(or already has one).