Update member function in isoSurface.C to support dynamic meshes#61
Update member function in isoSurface.C to support dynamic meshes#61ancolli wants to merge 2 commits intoDLR-RY:ci/of2406from
Conversation
resizing to cope with changing meshes
Update member function in isoSurface.C to support dynamic meshes
|
thanks for the PR can you merge into of2406? |
|
Done! |
isoAdvector
left a comment
isoAdvector
left a comment
There was a problem hiding this comment.
Looking good!
facePts seems to be unused - if so, remove. Same in isoAlpha.
By the way: Difference between isoAlpha and isoSurface needs documentation.
Current descritption in header of isoSurface.H: "Water saturation curve by Roche-Magnus"
Replace with proper description (main diff from isoAlpha: Support for LTS and dVf_ replaced by alphaPhi, if I remember correctly).
Should isoAlpha and isoSurface eventually be merged?
|
Hi, isoSurface is the only one working in my case. I did not go into the details of the differences between the two methods yet. Regarding the underlying theory, should I refer to: |
3 participants
Modified the member function to be compatible with changing meshes.
The implementation follows the approach used in isoAlpha.C, which has been verified to work correctly with mesh motion.