Skip to content

fix: prevent drop files overlay from appearing when dragging text #5312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oscar-escire wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −0
Open

fix: prevent drop files overlay from appearing when dragging text #5312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/app/shared/upload/file-dropzone-no-uploader/file-dropzone-no-uploader.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,11 @@ export class FileDropzoneNoUploaderComponent implements OnInit {

@HostListener('window:dragover', ['$event'])
onDragOver(event: DragEvent) {
// Only show drop area when dragging files or event is manually triggered
const hasFiles = event.dataTransfer?.types ? Array.from(event.dataTransfer.types).includes('Files') : true;
if (!hasFiles) {
return;
}
// Show drop area on the page
event.preventDefault();
event.stopPropagation();
Expand Down
5 changes: 5 additions & 0 deletions src/app/shared/upload/uploader/uploader.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,11 @@ export class UploaderComponent implements OnInit, AfterViewInit {
onDragOver(event: any) {

if (this.enableDragOverDocument && this.dragService.isAllowedDragOverPage()) {
// Only show drop area when dragging files or event is manually triggered
const hasFiles = event.dataTransfer?.types ? Array.from(event.dataTransfer.types).includes('Files') : true;
if (!hasFiles) {
return;
}
// Show drop area on the page
event.preventDefault();
if ((event.target as any).tagName !== 'HTML') {
Expand Down
Loading