Skip to content

Comments

Add a data_pending() method to Receiver#117

Merged
bieryAtFnal merged 4 commits intodevelopfrom
eflumerf/AddDataPending
Feb 11, 2026
Merged

Add a data_pending() method to Receiver#117
bieryAtFnal merged 4 commits intodevelopfrom
eflumerf/AddDataPending

Conversation

@eflumerf
Copy link
Member

@eflumerf eflumerf commented Jan 22, 2026

Description

Implement method required by DUNE-DAQ/iomanager#129, via the ZMQ_EVENTS ZeroMQ socket option.

Type of change

  • New feature or enhancement (non-breaking change which adds functionality)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (daqsystemtest_integtest_bundle.sh)

This change should be tested together with DUNE-DAQ/iomanager#129. N.B that we should also clone dfmodules, fdreadoutlibs, fdreadoutmodules, trigger, and hsilibs into our software areas when testing these changes.

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas

@eflumerf eflumerf self-assigned this Jan 22, 2026
@eflumerf eflumerf requested a review from bieryAtFnal January 22, 2026 20:06
@eflumerf eflumerf added the enhancement New feature or request label Jan 22, 2026
eflumerf and others added 2 commits February 3, 2026 10:42
@bieryAtFnal
Copy link
Contributor

@eflumerf , I needed to tweak a couple of lines in these changes as a result of the most recent merge from develop. Hopefully, these changes look reasonable...

Copy link
Contributor

@bieryAtFnal bieryAtFnal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me. I've tested them in conjunction with DUNE-DAQ/dfmodules#476, and they pass regression tests and are successfully used in draining the DataWriter input queue in the dfmodules changes.

@bieryAtFnal bieryAtFnal merged commit f5af0f1 into develop Feb 11, 2026
3 checks passed
@bieryAtFnal bieryAtFnal deleted the eflumerf/AddDataPending branch February 11, 2026 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants