Add simplified SPINE script for modern spine-prod configs#79
Add simplified SPINE script for modern spine-prod configs#79
spine-prod configs#79Conversation
run-mlreco/run_spine.spine-prod.sh
Outdated
| source install/spine-prod/configure.sh | ||
|
|
||
| # spine does something interesting with the output filename | ||
| actualOutFile=${tmpOutDir}/${inName}.LARCV_$(basename "$outFile" .hdf5).h5 |
There was a problem hiding this comment.
When I ran into this running the first NDLAr MiniProdN5 through SPINE, I fixed it at the spine-prod config level. @francois-drielsma and I have been discussing this config-based solution in this PR and it's likely not appropriate. However, before merging this PR, we should wait and see whether this "interesting" output filename behaviour is expected and whether team SPINE wish to fix it DeepLearnPhysics.
There was a problem hiding this comment.
We now have a new tag of spine which includes work done by Francois to (details in this closed PR) change this behaviour.
Now, when run is provided one input file and an explicitly set -o, the output file name will be exactly what was passed to -o.
alexbooth92
left a comment
alexbooth92
left a comment
There was a problem hiding this comment.
Apart from making a decision on what I've hightlighted in my inline comment, this all looks good to me, thanks Matt!
Update output file handling for spine tag v0.10.11.
2 participants
This adds a new script
run_spine.spine-prod.shthat sources spine-prod'sconfigure.sh(so that included yamls are properly found, etc.).The new script does away with the temp-dir creation / template substitution complexity of the old script, since it is no longer necessary with modern configs.
The interpretation of
ND_PRODUCTION_SPINE_CONFIGis simplified: It's just the path relative torun-mlreco; no more magic. So if you want to use a config fromspine-prod, it'll look likeinstall/spine-prod/.... If you want to use a config maintained within ND_Production, it'll start withconfigs/....Also, this catches up with SPINE's ongoing campaign to replace underscores with hyphens. A symlink from
spine-prodtospine_prodis created to ensure backward compatibility.Addresses #76
TODO:
infer/nd-lar/full_chain_260310.yaml