Component Type Form ID and Name Consistency Changes#427
Merged
bjrebel merged 9 commits intoproductionfrom Apr 15, 2026
Merged
Conversation
- reworked the JSON structure as per discussion with Hajime - the downloaded JSON file's name will now contain the name of the component in question - small change to internal variable naming, for clarity and consistency
Further changes to the HWDB info dump functionality ...
- there are 4 component types which have type form IDs and/or names which are inconsistent with all other types - want to clean these up - starting with 'Grounding Mesh Shipment' ... renamed to 'Grounding Mesh Panel Shipment' - changed all instances of the former in the code to the latter ... i.e. where an interface page layout is tailored to a specific component type, or where specific information is to be retrieved depending on the component type - administrator utility function set to directly change the 'formId' and 'formName' fields of all mesh shipment component records - note that a new component type form will need to be created through the interface, and the existing shipment reception action type form then edited to point to that (the old component type form can then be trashed)
- continuing with 'Wire Bobbin' ... the type form name remains the same, but the type form ID has been changed from 'wire_bobbin' to 'WireBobbin' - changed all instances of the former in the code to the latter - added to administrator utility, and removed 4 old component type form IDs and names from full component list (not currently used, so shouldn't make any difference until all changes have been made eventually) - note that a new component type form will need to be created through the interface, but no action type forms need to be changed
- continuing with 'Board Shipment' ... renamed to 'Geometry Board Shipment' - changed all instances of the former in the code to the latter, and added to adminstrator utility - corresponding changes to the two search functions that apply to geometry board shipments (library functions, routes and interface page file names) - note that a new component type form will need to be created through the interface, and the existing shipment-related actions then edited to point to that
Component Type Form ID and Name Consistency Changes (PR 1 of 2)
- continuing with 'APA Shipment' ... renamed to 'Assembled APA Shipment' - changed all instances of the former to the latter - additional code in the administrator utility function to change the 'path[0].formName' field in 'APA Post Production' workflows to be the new type form name - changed code for setting component names at creation to now use the updated type form names (previously, some types were using hardcoded naming because their type form names were different from desired ... not anymore)
Component Type Form ID and Name Consistency Changes (Part 4) ...
krishmaj
changed the title
bjrebel
approved these changes
Apr 15, 2026
Member
bjrebel
left a comment
bjrebel
left a comment
There was a problem hiding this comment.
Tested on staging, good to go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding new Daresbury technician to central list
Further changes to the HWDB info dump functionality
Component Type Form ID and Name Consistency Changes
Grounding Mesh Shipment (GroundingMeshShipment) --> Grounding Mesh Panel Shipment (GroundingMeshPanelShipment)
Note that for each component type, a new type form will need to be created through the interface, and any connected existing action and workflow type forms then edited to point to it (the old component type form can then be trashed)
Changes have been tested on Staging.