Merged
Conversation
Member
Author
|
After some thinking, I moved the conversion to In fact, no other code in our code base converts colors at shader parsing, they all do it in code closer to their processing code than the shader code is, so I feel doing it that ways keeps the programming pattern more unified, and then it's easier to search for things by expecting where things can be in a more predictable way. That's the only reason why I went for preferring this. |
04ef873 to
879b34c
Compare
Member
Author
|
This looks ready to me. |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick from #1730:
This one shouldn't be controversial.
One discussion possible is that we can do this conversion either in
tr_shader.cpp, either intr_bsp.cpp.Fog shaders should be parsed when requested by the BSP code, there is no meaning outside of that, so the behavior should be the same.