Discard old server commands upon new gamestate#1954
Open
slipher wants to merge 1 commit intoDaemonEngine:masterfrom
Open
Discard old server commands upon new gamestate#1954slipher wants to merge 1 commit intoDaemonEngine:masterfrom
slipher wants to merge 1 commit intoDaemonEngine:masterfrom
Conversation
Fixes Unvanquished/Unvanquished#1102. This fixes a bug where the configstring state could be wrong due to `cs` server commands being executed out of order with respect to game state processing. Server commands are only processed when the cgame requests a snapshot, so commands received before the client loads the current map which were sent before the gamestate could be processed after the gamestate. Of course there are other commands besides setting configstrings. In general, processing a command from a previous game seems very likely to be a bad idea and unlikely to be good.
slipher
force-pushed
the
configstring-fix
branch
from
ae4f051 to
409c253
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Unvanquished/Unvanquished#1102.
This fixes a bug where the configstring state could be wrong due to
csserver commands being executed out of order with respect to game state processing. Server commands are only processed when the cgame requests a snapshot, so commands received before the client loads the current map which were sent before the gamestate could be processed after the gamestate.