Read game information from daemon.ini file by illwieckz · Pull Request #588 · DaemonEngine/Daemon

illwieckz · 2022-02-27T22:12:32Z

Read game information from daemon.conf file, fix Unvanquished/Unvanquished#817:

Hardcoded references to Unvanquished in the engine Unvanquished/Unvanquished#817

See also Unvanquished/Unvanquished#1777 on Unvanquished side:

Add daemon.ini, write game-specific versions Unvanquished/Unvanquished#1777

This makes the engine truly repurposable without recompilation.

The idea is to set default home path, game name, game version, basepak, gamename string (thing used by master servers to filter out games), master servers, www_baseurl and uri proto (like unv in unv://) from a configuration file stored next to daemon binary.

This is based on @DefaultUser work.

This PR obsoletes #16:

WIP: Remove hardcoded Unvanquished references #16

Thing that is required to consider this PR complete:

Implement the master server list.

Thing that is outside of the scope of this PR:

Provide a generic Windows icon and a way for a game to compile the engine with a custom Windows icon.

…ished#817 Co-authored-by: Sebastian Schmidt <schro.sb@gmail.com> Co-authored-by: Thomas “illwieckz” Debesse <dev@illwieckz.net>

illwieckz · 2022-02-27T22:17:53Z

I have not implemented the master server list because I don't know how to do it.

illwieckz · 2022-02-27T22:19:35Z

Here is another gameinfo.conf syntax suggestion: #16 (comment)

We may also name the file game.conf or daemon.conf or something else.

illwieckz · 2022-02-28T22:01:02Z

I added an implementation of master server list from gameinfo.conf file. I find it a bit hacky and I'm not super happy with it but the problem is that the server master cvar list looks to be initialized before we read that file…

illwieckz · 2022-02-28T23:55:57Z

We MUST split on lines and consider everything following a key to be the value (stripping leading and trailing spaces. Especially, game names may contain white space! It looks like the current implementation iterates every word!

illwieckz · 2022-02-28T23:56:30Z

@Kangz you said there Unvanquished/Unvanquished#817 (comment)

This was on my TODO list after the "Application" refactor

So maybe this will interest you. I'll appreciate reviews and improvements. =)

illwieckz · 2022-03-01T12:35:34Z

Spearmint engine has a similar features with a file named mint-game.settings: https://github.com/zturtleman/spearmint/wiki/New-Game#game-separation

cvarDefault com_homepath "Jump Land Adventure"
cvarDefault com_gamename JumpLand
cvarDefault com_demoext jumplanddemo

This is similar to my suggest from #16 (comment)

slipher

The feature to override the default of any cvar sounds good (instead of only specifically allowed ones). We've talked about that sort of thing in the past, like maybe Xonotic would need to allow symlinks in paks by default or something.

Some other things I want to look at (I might fix them myself):

Don't add stuff to q_shared.h or qcommon.h
Avoid macros with va() or other function calls in them
Parsing should be case-insensitive
Consider moving CMake conf copying stuff into Daemon. It's similar to DLLs - a required file that must be copied to the engine dir.
Sanity check cvars that are used in filesystem paths

slipher · 2022-03-02T04:32:21Z

src/engine/framework/GameInfo.h

+	std::string uriprotocol() const;
+private:
+	Gameinfo() : _name("MISSING_NAME"), _version("UNKNOWN") {};
+	std::string _name;


I don't see any reason for private fields + getter functions. Just expose a const reference to a Gameinfo struct, and then the fields can be read (e.g. Gameinfo::getInstanc().basepak), but not modified.

That was code by @DefaultUser, if there is better way to do it then we can do it.

slipher · 2022-03-02T04:38:05Z

src/engine/qcommon/gameinfo.cpp

+		/* The key names and values MUST NOT be quoted
+		in the daemon.conf */
+
+		/* Display name, can contain special characters,


The documentation of each field should go in the struct definition rather than parsing code.

Alternatively the parser could support comments and this could go in the template. It's always annoying to use languages without comments...

We need a better parser anyway, I currently reused the one that was proposed in #16 but I'm not happy with it.

slipher · 2022-03-02T04:44:16Z

src/engine/server/sv_init.cpp

 	Cvar_Get( "layout", "", CVAR_SERVERINFO );
 	Cvar_Get( "g_layouts", "", 0 ); // FIXME
-	sv_hostname = Cvar_Get( "sv_hostname", UNNAMED_SERVER, CVAR_SERVERINFO  );
+	sv_hostname = Cvar_Get( "sv_hostname", Gameinfo::getInstance().unnamedservername().c_str(), CVAR_SERVERINFO  );


duplicated line

slipher · 2022-03-02T04:46:13Z

src/engine/qcommon/gameinfo.cpp

+	return temp;
+}
+
+std::string Gameinfo::name_upper() const


Yes, there are also some others to purge before merging (master ones).

src/common/Defs.h

illwieckz · 2026-04-07T12:35:55Z

Everything works but the master servers.

They are properly registered but the listing doesn't work. I suspect that the Cvar::Modified thing is messing with them.

illwieckz · 2026-04-07T12:44:23Z

We now use a .ini file which is read by using tomlc17:

https://github.com/cktan/tomlc17

This makes it easy to declare arrays, like master servers.

In the future we will be able to use an array as well for extra basepaks, the list of pak names to prevent accidental upgrade through autodownload.

illwieckz · 2026-04-07T13:25:10Z

The default sv_hostname is incorrect because it is set before the file is read.

We need a way to change a Cvar default after startup and set the cvar to this value when the hardcoded default wasn't modified.

illwieckz · 2026-04-07T13:39:13Z

The default sv_hostname is incorrect because it is set before the file is read.

Fixed.

Read game information from daemon.conf file, fix Unvanquished/Unvanqu…

ae9f00a

…ished#817 Co-authored-by: Sebastian Schmidt <schro.sb@gmail.com> Co-authored-by: Thomas “illwieckz” Debesse <dev@illwieckz.net>

This was referenced Feb 27, 2022

Add daemon.ini, write game-specific versions Unvanquished/Unvanquished#1777

Draft

WIP: Remove hardcoded Unvanquished references #16

Closed

illwieckz mentioned this pull request Feb 27, 2022

On reusability: how to stop suffering from “idtech is meant to be forked” mindset #339

Closed

illwieckz force-pushed the gameinfo/sync branch 2 times, most recently from 32aacdb to b418fcf Compare February 28, 2022 04:24

illwieckz added the T-Feature-Request Proposed new feature label Feb 28, 2022

illwieckz force-pushed the gameinfo/sync branch from b418fcf to 01c9ec8 Compare February 28, 2022 21:56

illwieckz force-pushed the gameinfo/sync branch from 01c9ec8 to 5971855 Compare February 28, 2022 22:02

illwieckz changed the title ~~Read game information from gameinfo.conf file, fix Unvanquished/Unvanquished#817~~ Read game information from daemon.conf file, fix Unvanquished/Unvanquished#817 Feb 28, 2022

illwieckz force-pushed the gameinfo/sync branch 4 times, most recently from daa987f to 6241602 Compare February 28, 2022 23:55

slipher reviewed Mar 2, 2022

View reviewed changes

illwieckz marked this pull request as draft March 7, 2022 00:11

illwieckz mentioned this pull request May 26, 2022

forbid the autodownload of unvanquished dpk #168

Open

illwieckz mentioned this pull request Oct 9, 2025

Customizability of console font #1844

Closed

illwieckz force-pushed the gameinfo/sync branch from 6241602 to d0f5e45 Compare April 7, 2026 12:30

illwieckz changed the title ~~Read game information from daemon.conf file, fix Unvanquished/Unvanquished#817~~ Read game information from daemon.ini file Apr 7, 2026

illwieckz force-pushed the gameinfo/sync branch from d0f5e45 to 86a5e79 Compare April 7, 2026 12:47

illwieckz mentioned this pull request Apr 7, 2026

Version parent issue Unvanquished/Unvanquished#3510

Open

illwieckz force-pushed the gameinfo/sync branch from 86a5e79 to d8f2382 Compare April 7, 2026 13:17

illwieckz force-pushed the gameinfo/sync branch from d8f2382 to 16c9a1f Compare April 7, 2026 13:39

illwieckz force-pushed the gameinfo/sync branch from 16c9a1f to ae9f00a Compare April 7, 2026 13:40

Conversation

illwieckz commented Feb 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

illwieckz commented Feb 27, 2022

Uh oh!

illwieckz commented Feb 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

illwieckz commented Feb 28, 2022

Uh oh!

illwieckz commented Feb 28, 2022

Uh oh!

illwieckz commented Feb 28, 2022

Uh oh!

illwieckz commented Mar 1, 2022

Uh oh!

slipher left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

illwieckz commented Apr 7, 2026

Uh oh!

illwieckz commented Apr 7, 2026

Uh oh!

illwieckz commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

illwieckz commented Apr 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

illwieckz commented Feb 27, 2022 •

edited

Loading

illwieckz commented Feb 27, 2022 •

edited

Loading

illwieckz commented Apr 7, 2026 •

edited

Loading